1528303 - After denying a microphone Android permission I'm getting a call to onMediaPermissionRequest

Status: RESOLVED FIXED

(GeckoView :: Media, defect, P1)

Description

[Arturo Mejia [:amejia]]

After denying a microphone Android permission (onAndroidPermissionsRequest) , I'm getting a call to onMediaPermissionRequest and I can even grant the permission.

This can be replicated on the GeckoView Example app.

Steps to reproduce

1. Go to https://permission.site/
2. Tap on the Microphone button
3. Tap on the "deny" button of the Android permission dialog.
4. Tap on the ok button of the site permission dialog.

Expected behavior

onMediaPermissionRequest must not be called after denying the Android permission.

Actual behavior

onMediaPermissionRequest is getting call after denying the Android permission.

Comment 1

[Emily Toop (:fluffyemily)]

For Camera, we save the android permission choice and then suppress the subsequent Media permission, but we don't do this for microphone access. We should treat these permissions the same. As we want to move to a situation where GV doesn't maintain any permissions state I shall move Camera to behave the same as the Microphone. This means that it is up to the consumer to remember any state and behave accordingly with regards to issuing a prompt for Media permissions.

I shall update GVE to reflect the actions that consumers would have to perform in order to produce the behaviour expected by permissions.site. It is recommended that Android Components handles this case.

Comment 2

[Emily Toop (:fluffyemily)]

Attachment: Bug 1528303 - Update GVE to demonstrate how to handle media permissions correctly

Update onMediaPermissionRequest documentation to better reflect usage

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b4eb5531f8e7
Update GVE to demonstrate how to handle media permissions correctly r=geckoview-reviewers,snorp

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/b4eb5531f8e7

Comment 5

[Chris Peterson [:cpeterson]]

Moving some media bugs to the new GeckoView::Media component.