Closed Bug 1528399 Opened 7 months ago Closed 7 months ago

arm64 trampolines align stack to 256 bytes (only 16 is required)

Categories

(Core :: JavaScript Engine: JIT, defect, P3)

ARM64
Unspecified
defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: mgaudet, Assigned: nbp)

References

(Blocks 1 open bug)

Details

(Whiteboard: [arm64:m3])

Attachments

(1 file)

Dmajor points out that our existing trampoline alignment code appears to be aligning the stack to 256-bytes, not 16 as required.

I expect the over-alignment is largely harmless, but we could save stack space by correcting this.

Marked as a dependent of Bug 1524419 to allow it to be resolved first.

Blocks: Fennec-ARM64
Assignee: nobody → nicolas.b.pierron
Status: NEW → ASSIGNED

Note: Bug 1524419 has a patch that would add another 256b alignment, it can be aligned to this if this lands first.

[arm64:m3] for Android

Whiteboard: [arm64:m3]
Pushed by npierron@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/08c00f2c0eab
ARM64: EnterJIT should align on 16 bytes instead of 256. r=sstangl
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.