1528451 - incorrect styling on moneysmart.gov.au

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Cameron McCormack (:heycam)]

STR:

1. Go to https://www.moneysmart.gov.au/investing/financial-advice/financial-advice-toolkit.
2. Mouse over the numbered items with the purple circles.
3. Notice that on mouse over the purple circle disappears, and after mousing out it doesn't reappear.

Expected results:

The background changes on hover and the purple circle doesn't disappear.

Comment 1

[Cameron McCormack (:heycam)]

12:17.32 INFO: Last good revision: dfefd2d4d63f8f2cdeb57e6ee16a8c31c4f54447
12:17.32 INFO: First bad revision: 6b71e3d434c232998629b8e18a983212e9d3fc9d
12:17.32 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=dfefd2d4d63f8f2cdeb57e6ee16a8c31c4f54447&tochange=6b71e3d434c232998629b8e18a983212e9d3fc9d

Looks like it's bug 1525134. Emilio, do you have time to take a look?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

.accordion-subSection h4:not(.noCircle)::first-letter {
    color: #ffffff;
    font-size: 1.5em;
    width: 1.4em;
    overflow: auto;
    display: inline-block;
    text-align: center;
    vertical-align: middle;
    margin-right: 0.5em;
    padding: 0.2em 0.5em;
    background: url("/media/559754/circle-6d3a96.svg") 0 0 no-repeat;
    background-size: contain;

}

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1528451 - Move code that starts image loads to DidSetComputedStyle.

This is more consistent with all the other image request code, and handles
pseudo-elements properly without having to add more out-of-band calls to
UpdateStyleOfOwnedChildFrame and such.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1528451 - Fix nsContinuingTextFrame::Init order.

So that the continuation pointer is setup before DidSetStyleContext runs.

I don't see any reason for not doing this, the current thing is a footgun.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d33544f0d8e6
Move code that starts image loads to DidSetComputedStyle. r=heycam

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15459 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/15459
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/AZ-yLQVDTGGOL5ZqAwjitQ)

Comment 9

[Andrei Ciure[:aciure]]

Backed out changeset d33544f0d8e6 (bug 1528451) for Assertion failure: IsResolved ...nsStyleStruct.h failures

push that caused the backout: https://hg.mozilla.org/integration/autoland/rev/d33544f0d8e6197126399ad928adc701582d947a

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=229167386&searchStr=windows%2C7%2Cdebug%2Cmochitests%2Cwith%2Ce10s%2Ctest-windows7-32%2Fdebug-mochitest-browser-chrome-e10s-2%2Cm-e10s%28bc2%29

backout: https://hg.mozilla.org/integration/autoland/rev/4af3691edfe75e542eb362b674cdfcc3aa5a81c8

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 11

[Emilio Cobos Álvarez (:emilio)]

There was a XUL subclass that only gets images on windows, which was not calling the base class' DidSetComputedStyle function.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2bbbcf59d8f9
Move code that starts image loads to DidSetComputedStyle. r=heycam

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2bbbcf59d8f9

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 15

[Intermittent Failures Robot]

3 failures in 2602 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3

Platform breakdown:

• linux64: 2
• windows10-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1528451&startday=2019-02-18&endday=2019-02-24&tree=all