Closed
Bug 1528464
Opened 5 years ago
Closed 5 years ago
Convert NS_STYLE_MASK_MODE_* to enum class
Categories
(Core :: CSS Parsing and Computation, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: al.dick, Assigned: al.dick)
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:65.0) Gecko/20100101 Firefox/65.0
Steps to reproduce:
this is a bug linked to bug 1277133
|
||
Comment 2•5 years ago
|
||
Did you mean to request review of that patch? It looks pretty good to me FWIW. You can do that from phabricator, Edit revision, then add someone to the "reviewers" field. You can add #style, for example.
Flags: needinfo?(al.dick)
I updated the patch. Do I need to request another review?
Flags: needinfo?(al.dick) → needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/38d48c5261aa Convert NS_STYLE_MASK_MODE_* to enum class r=emilio
|
|
||
Comment 5•5 years ago
|
||
Nope, once the patch is uploaded it goes back to the queue automatically. The patch looks great now, thanks! I landed it :)
Assignee: nobody → al.dick
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(emilio)
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•