1528469 - Devtools memory uses compartments as bounds for census operations instead of realms

Status: NEW

(DevTools :: Memory, defect, P3)

Description

[Jim Blandy :jimb]

Attachment: proof-of-concept patch

In the once-and-future multiple-globals-per-compartment world, a compartment may contain a mix of debuggee and non-debuggee realms. Census operations, whether implemented by Debugger.Memory.prototype.takeCensus or ChromeUtils.saveHeapSnapshot, should consider only those nodes that fall in debuggee realms (if the nodes in question belong to any realm at all).

Attached is a patch that changes the census functions to hew more closely to the set of debugggees. It needs to be broken up for review and earn a clean try push, but the overall approach, I think, is okay. Feedback welcome!

Comment 1

[Jim Blandy :jimb]

Attachment: Proof-of-concept patch

Rebased to Mozilla Central 395a65d512e3 (Mon 2019-4-8).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last months and this bug has priority 'P2'.
:julienw, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Julien Wajsberg [:julienw]]

Pretty sure Jim is still around, but also pretty sure the patch won't be finished soon. Reducing the priority then.

Comment 4

[Suhaib Mujahid [:suhaib]]

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.