1528600 - Change some global widget/cocoa functions to static

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement, P3)

Description

[Chris Peterson [:cpeterson]]

clang's -Wmissing-prototypes option can identify global functions that can be made static (because they are only called from one compilation unit) or removed (if they are never called).

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1528600 - widget/cocoa: Change some global functions to static. r?mstange

widget/cocoa/nsChildView.mm:1932:21 [-Wmissing-prototypes] no previous prototype for function 'TextureSizeForSize'
widget/cocoa/nsCocoaUtils.mm:351:6 [-Wmissing-prototypes] no previous prototype for function 'data_ss_release_callback'

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: Bug 1528600 - widget/cocoa: Remove empty function EnsureLogInitialized(). r?mstange

widget/cocoa/nsChildView.mm:249:6 [-Wmissing-prototypes] no previous prototype for function 'EnsureLogInitialized'

Depends on D20087

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/134db05991c2
widget/cocoa: Change some global functions to static. r=mstange
https://hg.mozilla.org/integration/autoland/rev/b255d130f718
widget/cocoa: Remove empty function EnsureLogInitialized(). r=mstange

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/134db05991c2
https://hg.mozilla.org/mozilla-central/rev/b255d130f718