Closed Bug 1528600 Opened 4 years ago Closed 4 years ago

Change some global widget/cocoa functions to static

Categories

(Core :: Widget: Cocoa, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox-esr60 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

clang's -Wmissing-prototypes option can identify global functions that can be made static (because they are only called from one compilation unit) or removed (if they are never called).

widget/cocoa/nsChildView.mm:1932:21 [-Wmissing-prototypes] no previous prototype for function 'TextureSizeForSize'
widget/cocoa/nsCocoaUtils.mm:351:6 [-Wmissing-prototypes] no previous prototype for function 'data_ss_release_callback'

widget/cocoa/nsChildView.mm:249:6 [-Wmissing-prototypes] no previous prototype for function 'EnsureLogInitialized'

Depends on D20087

Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/134db05991c2
widget/cocoa: Change some global functions to static. r=mstange
https://hg.mozilla.org/integration/autoland/rev/b255d130f718
widget/cocoa: Remove empty function EnsureLogInitialized(). r=mstange
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Blocks: 536427
See Also: 536427
You need to log in before you can comment on or make changes to this bug.