Closed Bug 1528651 Opened 9 months ago Closed 9 months ago

Re-enable warnings-as-errors on Windows in some directories

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox67 fixed)

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: emk, Assigned: emk)

References

(Blocks 1 open bug)

Details

Attachments

(6 files, 3 obsolete files)

20.41 KB, patch
emk
: review+
Details | Diff | Splinter Review
3.83 KB, patch
aklotz
: review+
Details | Diff | Splinter Review
28.28 KB, patch
emk
: review+
Details | Diff | Splinter Review
1.50 KB, patch
aklotz
: review+
Details | Diff | Splinter Review
979 bytes, patch
aklotz
: review+
Details | Diff | Splinter Review
47 bytes, text/x-phabricator-request
Details | Review

People already fixed many warnings without re-enabling warnings-as-errors.

I believe that C++ changes are trivial enough so no module-specific knowledges are required.
Attachment #9044588 - Flags: review?(dmajor)
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment on attachment 9044588 [details] [diff] [review]
Re-enable warnings-as-errors on Windows in some directories

\o/ I'm glad to see that we can remove so many of these!

Could you please split this up into two patches:
- Directories where the only change is removing the AllowCompilerWarnings() (you can consider this piece r+ already)
- All other changes

This would let us get the easy stuff out of the way and make it easier to review the c++ changes. Thanks!
Attachment #9044588 - Flags: review?(dmajor)
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dd188d3b0907
Re-enable warnings-as-errors on Windows in some directories. r=dmajor
Attachment #9044588 - Attachment is obsolete: true
Attachment #9044915 - Attachment description: Re-enable warnings-as-errors on Windows in some directories → Re-enable warnings-as-errors on Windows in some directories [landed in comment #5]
Attachment #9044915 - Flags: review+
Keywords: leave-open
Comment on attachment 9044919 [details] [diff] [review]
Fix some trivial warnings and re-enable warnings-as-errors on Windows in some directories

Review of attachment 9044919 [details] [diff] [review]:
-----------------------------------------------------------------

Looking great, a few small requests...

::: gfx/thebes/DeviceManagerDx.cpp
@@ +102,5 @@
>  }
>  
>  bool DeviceManagerDx::LoadDcomp() {
>    FeatureState& d3d11 = gfxConfig::GetFeature(Feature::D3D11_COMPOSITING);
> +  MOZ_ALWAYS_TRUE(d3d11.IsEnabled());

MOZ_ALWAYS_TRUE feels like the wrong solution to the problem. It makes release builds call d3d11.IsEnabled() even though they don't care about the answer.

I think it would be better to use DebugOnly<> here.

Or alternatively, MOZ_ASSERT(gfxConfig::GetFeature(Feature::D3D11_COMPOSITING).IsEnabled()).

::: ipc/chromium/src/base/string_util_win.h
@@ +19,5 @@
>  // Chromium code style is to not use malloc'd strings; this is only for use
>  // for interaction with APIs that require it.
>  inline char* strdup(const char* str) { return _strdup(str); }
>  
> +#ifndef strcasecmp

This workaround looks kind of odd. Can we just remove these functions? I don't see any code that uses them.

::: ipc/chromium/src/base/win_util.cc
@@ +16,5 @@
>  
>  std::wstring FormatMessage(unsigned messageid) {
>    wchar_t* string_buffer = NULL;
> +  ::FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM |
> +                      FORMAT_MESSAGE_IGNORE_INSERTS,

Nit: the spacing is misaligned.

::: ipc/mscom/Registration.cpp
@@ +414,5 @@
>      }
>  #endif
>    }
>  
> +  MOZ_ALWAYS_TRUE(sRegistry->emplaceBack(aProxy));

As mscom is a relatively new module and I'm not familiar with its conventions, could you please split this directory into a separate patch and ask aklotz to review?

::: memory/build/mozjemalloc.cpp
@@ +4348,5 @@
>    }
>  #define MALLOC_FUNCS MALLOC_FUNCS_MALLOC_BASE
>  #include "malloc_decls.h"
>  
> +#ifndef XP_WIN

This condition splits the comment blocks, it might look better as:

// End non-standard functions.
// ***************************************************************************
#ifndef XP_WIN
// Begin library-private functions, used by threading libraries for protection	
...
// End library-private functions.
#endif

@@ +4355,5 @@
>  // Begin library-private functions, used by threading libraries for protection
>  // of malloc during fork().  These functions are only called if the program is
>  // running in threaded mode, so there is no need to check whether the program
>  // is threaded here.
>  #ifndef XP_DARWIN

This ifndef should be indented.

::: memory/replace/dmd/DMD.cpp
@@ +1355,1 @@
>  static void prefork() {

I don't see any callers of these functions. Can we just remove them?

::: memory/replace/logalloc/LogAlloc.cpp
@@ +26,5 @@
>  static bool sStdoutOrStderr = false;
>  
>  static Mutex sMutex;
>  
> +#ifndef _WIN32

Same here: can we remove these functions?

::: netwerk/wifi/win_wifiScanner.cpp
@@ +41,5 @@
>    volatile uint32_t mCurrentlyScanningInterfaces;
>    HANDLE mAllInterfacesDoneScanningEvent;
>  };
>  
> +static void CALLBACK OnScanComplete(PWLAN_NOTIFICATION_DATA data,

wlanapi.h writes this as `WINAPI` so we might as well match it.
Attachment #9044919 - Flags: review?(dmajor)
Comment on attachment 9044919 [details] [diff] [review]
Fix some trivial warnings and re-enable warnings-as-errors on Windows in some directories

Review of attachment 9044919 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/DeviceManagerDx.cpp
@@ +102,5 @@
>  }
>  
>  bool DeviceManagerDx::LoadDcomp() {
>    FeatureState& d3d11 = gfxConfig::GetFeature(Feature::D3D11_COMPOSITING);
> +  MOZ_ALWAYS_TRUE(d3d11.IsEnabled());

Since `DebugOnly` does not support references, I took the latter way.

::: ipc/chromium/src/base/string_util_win.h
@@ +19,5 @@
>  // Chromium code style is to not use malloc'd strings; this is only for use
>  // for interaction with APIs that require it.
>  inline char* strdup(const char* str) { return _strdup(str); }
>  
> +#ifndef strcasecmp

Removed.

::: ipc/chromium/src/base/win_util.cc
@@ +16,5 @@
>  
>  std::wstring FormatMessage(unsigned messageid) {
>    wchar_t* string_buffer = NULL;
> +  ::FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM |
> +                      FORMAT_MESSAGE_IGNORE_INSERTS,

It is what clang-format did. I guess clang-format tried to make it easier to distinguish the second line of the first parameter from the following parameters.

::: ipc/mscom/Registration.cpp
@@ +414,5 @@
>      }
>  #endif
>    }
>  
> +  MOZ_ALWAYS_TRUE(sRegistry->emplaceBack(aProxy));

OK.

::: memory/build/mozjemalloc.cpp
@@ +4348,5 @@
>    }
>  #define MALLOC_FUNCS MALLOC_FUNCS_MALLOC_BASE
>  #include "malloc_decls.h"
>  
> +#ifndef XP_WIN

Done.

@@ +4355,5 @@
>  // Begin library-private functions, used by threading libraries for protection
>  // of malloc during fork().  These functions are only called if the program is
>  // running in threaded mode, so there is no need to check whether the program
>  // is threaded here.
>  #ifndef XP_DARWIN

Done.

::: memory/replace/dmd/DMD.cpp
@@ +1355,1 @@
>  static void prefork() {

`mozilla::dmd::Init` took a pointer to them on non-Windows platforms:
https://searchfox.org/mozilla-central/rev/93905b660fc99a5d52b683690dd26471daca08c8/memory/replace/dmd/DMD.cpp#1392

::: memory/replace/logalloc/LogAlloc.cpp
@@ +26,5 @@
>  static bool sStdoutOrStderr = false;
>  
>  static Mutex sMutex;
>  
> +#ifndef _WIN32

Same as the above (but `replace_init` instead of `mozilla::dmd::Init`):
https://searchfox.org/mozilla-central/rev/93905b660fc99a5d52b683690dd26471daca08c8/memory/replace/logalloc/LogAlloc.cpp#227

::: netwerk/wifi/win_wifiScanner.cpp
@@ +41,5 @@
>    volatile uint32_t mCurrentlyScanningInterfaces;
>    HANDLE mAllInterfacesDoneScanningEvent;
>  };
>  
> +static void CALLBACK OnScanComplete(PWLAN_NOTIFICATION_DATA data,

Done.
Attachment #9044919 - Attachment is obsolete: true
Comment on attachment 9045200 [details] [diff] [review]
Fix some trivial warnings and re-enable warnings-as-errors on Windows in some directories

Review of attachment 9045200 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

::: memory/build/mozjemalloc.cpp
@@ +4356,5 @@
>  // of malloc during fork().  These functions are only called if the program is
>  // running in threaded mode, so there is no need to check whether the program
>  // is threaded here.
>  #ifndef XP_DARWIN
>  static

It looks like this file didn't get refreshed... the `ifndef XP_DARWIN` is still missing an indent, and the `ifndef XP_WIN` is still in an akward place relative to the comment blocks.

::: netwerk/wifi/win_wifiScanner.cpp
@@ +41,5 @@
>    volatile uint32_t mCurrentlyScanningInterfaces;
>    HANDLE mAllInterfacesDoneScanningEvent;
>  };
>  
> +static void CALLBACK OnScanComplete(PWLAN_NOTIFICATION_DATA data,

This one still has CALLBACK instead of WINAPI.
Attachment #9045200 - Flags: review?(dmajor) → review+
Ugh, I was working on the wrong local repo, sorry.
Attachment #9045200 - Attachment is obsolete: true
Attachment #9045232 - Flags: review+
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b9c19a2b4854
Fix some trivial warnings and re-enable warnings-as-errors on Windows in some directories. r=dmajor
Attachment #9045199 - Flags: review?(aklotz) → review+

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/045596fde4d0
Fix warnings and re-enable warnings-as-errors in ipc/mscom/. r=aklotz

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Backed out 2 changesets (Bug 1528651) for bustages on ipc/mscom/ on beta sim

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel%2Crunnable&revision=f90c4c2d083917f932bf7f8b6383b92d432c923d&selectedJob=229638587

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229649041&repo=try&lineNumber=14910

Backout link: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=5146d32ab40fab0cd70dfb33c02c7fa0afcf1926

15:20:54 INFO - ipc/glue/Unified_cpp_ipc_glue1.i_o
15:20:54 INFO - mozmake.EXE[5]: Leaving directory 'z:/task_1550761006/build/src/obj-firefox/ipc/glue'
15:20:54 INFO - mozmake.EXE[5]: Entering directory 'z:/task_1550761006/build/src/obj-firefox/ipc/mscom/oop'
15:20:54 INFO - z:/task_1550761006/build/src/clang/bin/clang.exe --driver-mode=cl -m32 -FoActivationContext.i_o -c -DNDEBUG=1 -DTRIMMED=1 -D_UNICODE -DMOZ_NO_MOZALLOC -DUNICODE -DMOZ_MSCOM_REMARSHAL_NO_HANDLER -Iz:/task_1550761006/build/src/ipc/mscom/oop -Iz:/task_1550761006/build/src/obj-firefox/ipc/mscom/oop -Iz:/task_1550761006/build/src/obj-firefox/dist/include -Iz:/task_1550761006/build/src/obj-firefox/dist/include/nspr -Iz:/task_1550761006/build/src/obj-firefox/dist/include/nss -MT -FI z:/task_1550761006/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -guard:cf -Qunused-arguments -fcrash-diagnostics-dir=z:/task_1550761006/public/build -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -guard:cf -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang z:/task_1550761006/build/src/obj-firefox/build/clang-plugin/clang-plugin.dll -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -WX -fprofile-instr-generate -Xclang -MP -Xclang -dependency-file -Xclang .deps/ActivationContext.i_o.pp -Xclang -MT -Xclang ActivationContext.i_o z:/task_1550761006/build/src/ipc/mscom/ActivationContext.cpp
15:20:54 INFO - z:/task_1550761006/build/src/ipc/mscom/ActivationContext.cpp(200,8): error: unused variable 'activated' [-Werror,-Wunused-variable]
15:20:54 INFO - BOOL activated = ::ActivateActCtx(mActCtx.mActCtx, &mActCookie);
15:20:54 INFO - ^
15:20:54 INFO - 1 error generated.
15:20:54 INFO - z:/task_1550761006/build/src/config/rules.mk:805: recipe for target 'ActivationContext.i_o' failed
15:20:54 INFO - mozmake.EXE[5]: *** [ActivationContext.i_o] Error 1
15:20:54 INFO - mozmake.EXE[5]: Leaving directory 'z:/task_1550761006/build/src/obj-firefox/ipc/mscom/oop'
15:20:54 INFO - z:/task_1550761006/build/src/config/recurse.mk:74: recipe for target 'ipc/mscom/oop/target' failed
15:20:54 INFO - mozmake.EXE[4]: *** [ipc/mscom/oop/target] Error 2
15:20:54 INFO - mozmake.EXE[4]: *** Waiting for unfinished jobs....
15:20:54 INFO - mozmake.EXE[5]: Entering directory 'z:/task_1550761006/build/src/obj-firefox/ipc/ipdl'
15:20:54 INFO - ipc/ipdl/UnifiedProtocols19.i_o
15:20:54 INFO - mozmake.EXE[5]: Leaving directory 'z:/task_1550761006/build/src/obj-firefox/ipc/ipdl'
15:20:55 INFO - mozmake.EXE[5]: Entering directory 'z:/task_1550761006/build/src/obj-firefox/ipc/chromium'
15:20:55 INFO - z:/task_1550761006/build/src/clang/bin/clang.exe --driver-mode=cl -m32 -Fowin_util.i_o -c -Iz:/task_1550761006/build/src/obj-firefox/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/task_1550761006/build/src/ipc/chromium -Iz:/task_1550761006/build/src/obj-firefox/ipc/chromium -Iz:/task_1550761006/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/task_1550761006/build/src/ipc/chromium/src -Iz:/task_1550761006/build/src/ipc/glue -Iz:/task_1550761006/build/src/obj-firefox/dist/include -Iz:/task_1550761006/build/src/obj-firefox/dist/include/nspr -Iz:/task_1550761006/build/src/obj-firefox/dist/include/nss -MD -FI z:/task_1550761006/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -guard:cf -Qunused-arguments -fcrash-diagnostics-dir=z:/task_1550761006/public/build -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -guard:cf -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang z:/task_1550761006/build/src/obj-firefox/build/clang-plugin/clang-plugin.dll -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -WX -fprofile-instr-generate -Xclang -finstrument-functions-after-inlining -Xclang -MP -Xclang -dependency-file -Xclang .deps/win_util.i_o.pp -Xclang -MT -Xclang win_util.i_o z:/task_1550761006/build/src/ipc/chromium/src/base/win_util.cc
15:20:55 INFO - mozmake.EXE[5]: Leaving directory 'z:/task_1550761006/build/src/obj-firefox/ipc/chromium'
15:20:55 INFO - mozmake.EXE[5]: Entering directory 'z:/task_1550761006/build/src/obj-firefox/ipc/chromium'
15:20:55 INFO - ipc/chromium/ipc_channel_win.i_o
15:20:55 INFO - mozmake.EXE[5]: Leaving directory 'z:/task_1550761006/build/src/obj-firefox/ipc/chromium'
15:20:56 INFO - mozmake.EXE[5]: Entering directory 'z:/task_1550761006/build/src/obj-firefox/ipc/mscom'
15:20:56 INFO - z:/task_1550761006/build/src/clang/bin/clang.exe --driver-mode=cl -m32 -FoSpinEvent.i_o -c -Iz:/task_1550761006/build/src/obj-firefox/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DMOZ_MSCOM_REMARSHAL_NO_HANDLER -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/task_1550761006/build/src/ipc/mscom -Iz:/task_1550761006/build/src/obj-firefox/ipc/mscom -Iz:/task_1550761006/build/src/xpcom/base -Iz:/task_1550761006/build/src/xpcom/build -Iz:/task_1550761006/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/task_1550761006/build/src/ipc/chromium/src -Iz:/task_1550761006/build/src/ipc/glue -Iz:/task_1550761006/build/src/obj-firefox/dist/include -Iz:/task_1550761006/build/src/obj-firefox/dist/include/nspr -Iz:/task_1550761006/build/src/obj-firefox/dist/include/nss -MD -FI z:/task_1550761006/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -guard:cf -Qunused-arguments -fcrash-diagnostics-dir=z:/task_1550761006/public/build -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -guard:cf -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang z:/task_1550761006/build/src/obj-firefox/build/clang-plugin/clang-plugin.dll -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -WX -fprofile-instr-generate -Xclang -finstrument-functions-after-inlining -Xclang -MP -Xclang -dependency-file -Xclang .deps/SpinEvent.i_o.pp -Xclang -MT -Xclang SpinEvent.i_o z:/task_1550761006/build/src/ipc/mscom/SpinEvent.cpp
15:20:56 INFO - mozmake.EXE[5]: Leaving directory 'z:/task_1550761006/build/src/obj-firefox/ipc/mscom'
15:20:56 INFO - mozmake.EXE[5]: Entering directory 'z:/task_1550761006/build/src/obj-firefox/ipc/mscom'
15:20:56 INFO - ipc/mscom/WeakRef.i_o
15:20:56 INFO - mozmake.EXE[5]: Leaving directory 'z:/task_1550761006/build/src/obj-firefox/ipc/mscom'
15:20:57 INFO - mozmake.EXE[5]: Entering directory 'z:/task_1550761006/build/src/obj-firefox/ipc/glue'
15:20:57 INFO - z:/task_1550761006/build/src/clang/bin/clang.exe --driver-mode=cl -m32 -FoWindowsMessageLoop.i_o -c -Iz:/task_1550761006/build/src/obj-firefox/dist/stl_wrappers -DNDEBUG=1 -DTRIMMED=1 -DHAVE_UINT64_T -DWEBRTC_WIN -DHAVE_WINSOCK2_H -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC '-DMOZ_CHILD_PROCESS_NAME="plugin-container.exe"' '-DMOZ_CHILD_PROCESS_BUNDLE="plugin-container.app/Contents/MacOS/"' -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/task_1550761006/build/src/ipc/glue -Iz:/task_1550761006/build/src/obj-firefox/ipc/glue -Iz:/task_1550761006/build/src/caps -Iz:/task_1550761006/build/src/dom/broadcastchannel -Iz:/task_1550761006/build/src/dom/indexedDB -Iz:/task_1550761006/build/src/dom/storage -Iz:/task_1550761006/build/src/media/webrtc/trunk -Iz:/task_1550761006/build/src/media/webrtc/trunk/webrtc -Iz:/task_1550761006/build/src/xpcom/build -Iz:/task_1550761006/build/src/dom/ipc -Iz:/task_1550761006/build/src/toolkit/crashreporter -Iz:/task_1550761006/build/src/toolkit/xre -Iz:/task_1550761006/build/src/xpcom/threads -Iz:/task_1550761006/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/task_1550761006/build/src/ipc/chromium/src -Iz:/task_1550761006/build/src/ipc/glue -Iz:/task_1550761006/build/src/security/sandbox/chromium -Iz:/task_1550761006/build/src/security/sandbox/chromium-shim -Iz:/task_1550761006/build/src/security/sandbox/win/src/sandboxbroker -Iz:/task_1550761006/build/src/obj-firefox/dist/include -Iz:/task_1550761006/build/src/obj-firefox/dist/include/nspr -Iz:/task_1550761006/build/src/obj-firefox/dist/include/nss -MD -FI z:/task_1550761006/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -Qunused-arguments -guard:cf -Qunused-arguments -fcrash-diagnostics-dir=z:/task_1550761006/public/build -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -guard:cf -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -Wno-inline-new-delete -Wno-invalid-offsetof -Wno-microsoft-enum-value -Wno-microsoft-include -Wno-unknown-pragmas -Wno-ignored-pragmas -Wno-deprecated-declarations -Wno-invalid-noreturn -Wno-inconsistent-missing-override -Wno-implicit-exception-spec-mismatch -Wno-unused-local-typedef -Wno-ignored-attributes -Wno-used-but-marked-unused -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Z7 -Xclang -load -Xclang z:/task_1550761006/build/src/obj-firefox/build/clang-plugin/clang-plugin.dll -Xclang -add-plugin -Xclang moz-check -O2 -Oy- -WX -fprofile-instr-generate -Xclang -finstrument-functions-after-inlining -Xclang -MP -Xclang -dependency-file -Xclang .deps/WindowsMessageLoop.i_o.pp -Xclang -MT -Xclang WindowsMessageLoop.i_o z:/task_1550761006/build/src/ipc/glue/WindowsMessageLoop.cpp
15:20:57 INFO - mozmake.EXE[5]: Leaving directory 'z:/task_1550761006/build/src/obj-firefox/ipc/glue'
15:20:57 INFO - mozmake.EXE[5]: Entering directory 'z:/task_1550761006/build/src/obj-firefox/ipc/ipdl'
15:20:57 INFO - ipc/ipdl/UnifiedProtocols2.i_o

Flags: needinfo?(VYV03354)
I'll fold this to the previous patch on re-landing.
Attachment #9046058 - Flags: review?(aklotz)
Flags: needinfo?(VYV03354)
Attachment #9046058 - Flags: review?(aklotz) → review+
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/90ec592466c0
Followup to fix a warning on release or beta. r=aklotz

Umm, are mingw-clang builds disabling replace-malloc? mozilla::Unused should be available if replace-malloc is enabled:
https://searchfox.org/mozilla-central/rev/b10ae6b7a50d176a813900cbe9dc18c85acd604b/memory/replace/logalloc/replay/moz.build#14

Flags: needinfo?(VYV03354)
I stopped using mozilla::Unused.
Attachment #9047400 - Flags: review?(aklotz)

(In reply to Masatoshi Kimura [:emk] from comment #25)

Created attachment 9047400 [details] [diff] [review]
Followup to fix a warning on release or beta

I stopped using mozilla::Unused.

FWIW with this patch applied I still see errors on beta/release builds: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=231072755&repo=try&lineNumber=14830

Attachment #9047400 - Flags: review?(aklotz) → review+
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ce3a685bbcd
Followup to fix a warning on release or beta. r=aklotz

Beta simulation is green on try run with this patch and a patch from bug 1428158 included:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=24e838e7e4e2e8724fa8b26ce3184c4a74bc28ec

Not sure why but all my attempts at beta simulations were still showing build errors in ipc/mscom. I ended up needing to test with this in order to fix them: https://hg.mozilla.org/try/rev/aa63c93be5792ed1b16c6d4e151ed41883db9a8d

This is maddening. I'm half tempted to propose that we change the no-op case to something like:

#define MOZ_ASSERT(x) (void)reinterpret_cast<decltype(x)*>(0)

So that we "use" the variable but don't evaluate it.

(In reply to Dave Townsend [:mossop] (he/him) from comment #31)

Not sure why but all my attempts at beta simulations were still showing build errors in ipc/mscom. I ended up needing to test with this in order to fix them: https://hg.mozilla.org/try/rev/aa63c93be5792ed1b16c6d4e151ed41883db9a8d

It is the same as my comment #29 patch.

(In reply to Masatoshi Kimura [:emk] from comment #33)

(In reply to Dave Townsend [:mossop] (he/him) from comment #31)

Not sure why but all my attempts at beta simulations were still showing build errors in ipc/mscom. I ended up needing to test with this in order to fix them: https://hg.mozilla.org/try/rev/aa63c93be5792ed1b16c6d4e151ed41883db9a8d

It is the same as my comment #29 patch.

Is there a reason you haven't requested review on it then?

(In reply to Dave Townsend [:mossop] (he/him) from comment #34)

Is there a reason you haven't requested review on it then?

I already requested a review, was approved for landing, and requested landing via Lando. (Phabricator activities are not visible from Bugzilla.)

Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/a67f7ae04858
Another follow-up to fix warnings on beta/release builds. r=aklotz
Depends on: 1532959
Duplicate of this bug: 1524423
Duplicate of this bug: 1523455
You need to log in before you can comment on or make changes to this bug.