152874 - add method of HTML SelectElement doesn't appear to work

Status: RESOLVED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Mike Wexler]

var secondaryMenu = (theMenu.selectedIndex-1);
	menu2 = document.getElementById(targetMenu);
	var end=menu2.length;
	for (i=0; i < end; i++) {
			menu2.remove(0);
	}
	
	i=0;
	for (i=0; i < menu[secondaryMenu][0].length; i++) {
		var newElem = document.createElement("OPTION");
		newElem.text = menu[secondaryMenu][text][i];
		newElem.value = menu[secondaryMenu][value][i];
		menu2.add(newElem);
	}
}

the menu2.add should add the option element to menu2. But it doesn't appear to.
Instead there is only one entry with a value of "c"

This works on MSIE 6.0 and follows the spec at
http://www.w3.org/TR/2002/CR-DOM-Level-2-HTML-20020605/DOM2-HTML.html#html-ID-30606413

Comment 1

[Boris Zbarsky [:bzbarsky]]

The code in the testcase is incorrect... it has:

		menu2.add(newElem);

while at
http://www.w3.org/TR/2002/CR-DOM-Level-2-HTML-20020605/DOM2-HTML.html#html-ID-94282980
we see that the add() method takes _2_ arguments:

  void               add(in HTMLElement element, 
                         in HTMLElement before)
                                        raises(DOMException);

Not passing that second argument causes add() to throw the following exception:

[Exception... "Not enough arguments [nsIDOMHTMLSelectElement.add]"]

Marking bug invalid; if I fix the call to add() to be correct it works fine.