1528836 - Allow "check_port_available()" to raise socket errors

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Currently we hide the error as raised by socket.bind() inside of is_port_available because this method is only allowed to return a boolean.

It would be better to allow this method to raise an error, so it can be re-used in calling code for better error messages.

We would need that to easier analyze what's happening on bug 1527963.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Lets make the initial request part of the more pressing one. As noticed when using ncap locally and keeping the port 2828 in use, Marionette didn't detect that and happily started Firefox. But then it was failing to connect to the server, and instead connected to ncap which times out after 120s.

So the initial port probe shouldn't make use of "SO_REUSEADDR".

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a131b47aaca487b538fd7c521fe622782060b614

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We actually cannot remove this socket option because it would result in failures for restart tests. As such lets try to keep this bug simple and only make the check_port_available method more verbose.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8bb5003149baf3d1d51fe4091c5e0047c87c541e

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1528836 - [marionette] Allow check_for_port to raise exceptions. r?automatedtester

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/81945490d433
[marionette] Allow check_for_port to raise exceptions. r=automatedtester

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/81945490d433

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Is this something you intend for beta uplift?

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, for failure inspection it would be great to have this test-only patch uplifted to beta.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request uplift.... or just land it :)

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a548506067f8