convert #define NS_STYLE_FLEX_DIRECTION values to enum class in nsStyleConsts.h

RESOLVED FIXED in Firefox 67

Status

()

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Status:
RESOLVED FIXED
Reported:
3 months ago
Modified:
3 months ago

People

(Reporter: asfiyab95, Assigned: asfiyab95)

Tracking

(Blocks 1 bug)

Version:
Trunk
Target:
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

convert NS_STYLE_FLEX_DIRECTION to an enum class in nsStyleConsts.h
47 bytes, text/x-phabricator-request
Details | Review
(Assignee)

Description

•
3 months ago

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce:

convert #define NS_STYLE_FLEX_DIRECTION values to enum class in nsStyleConsts.h

grep 'NS_STYLE_FLEX_DIRECTION' and replace it with the enum values

Actual results:

Successful Compilation

Expected results:

Successful compilation
(Assignee)

Comment 1

•
3 months ago

Converted the #define variable NS_STYLE_FLEX_DIRECTION to an enum class in nsStyleConsts.h and made changes in other files that access it

Assignee: nobody → asfiyab95
Status: UNCONFIRMED → ASSIGNED
Component: Untriaged → CSS Parsing and Computation
Ever confirmed: true
Product: Firefox → Core
Version: 1.0 Branch → Trunk

Comment 2

•
3 months ago 
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/85192f61b49e
convert NS_STYLE_FLEX_DIRECTION to an enum class in nsStyleConsts.h r=emilio

Comment 3

•
3 months ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/85192f61b49e

Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.