15291 - Pop3 local mail folder line ending not following the platform standard

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[jefft]

On Windows it's okay, always end with \r\n. On Mac we are intermixed with \r\n
and \r, which is wrong. (On Linux, don't know yet.) This causes message headers
not parsing correctly on Mac. The problem can be observed by copying news
messages to a pop3 folder on a Mac. We need to make sure that messages in a
local mail folder, every line ends with appropriate platform specific line
endings (Windows - CRLF, MAC - CR, UNIX - LF).

Comment 1

[Phil Peterson]

Reassign to mscott, cc bienvenu

Comment 2

[David :Bienvenu]

Phil, this isn't the parsing code I was talking about, but rather, the code that
writes to the folder. It's not the POP3 code either, but the msg copy
streaming code.

Comment 3

[Scott MacGregor]

Jeff, I think this is your bug....shouldn't it be up to the message copy stream
listener stuff to figure out what kind of line endings it wants when doing a
copy? Oh wait, that's pretty much what david b just said as well...I'm just
streaming the data straight from the berkley mail folder to the copy stream
listener.

Maybe the bug is in the code that writes to the berkley mail folder which would
be code intiated by the pop3 protocol...

Comment 4

[Scott MacGregor]

Jefft said he knew how to fix this. Re-assiging to him =)

Comment 5

[jefft]

Replacing CRLF with MSG_LINEBREAK. nsPop3Protocol.cpp nsPop3Sink.cpp changed.

Comment 6

[lchiang]

Par, pls verify.

Comment 7

[ppandit]

from nsCRT.h:
#ifdef XP_MAC
#  define NS_LINEBREAK             "\015"
#  define NS_LINEBREAK_LEN 1
#else
#  ifdef XP_PC
#    define NS_LINEBREAK           "\015\012"
#    define NS_LINEBREAK_LEN       2
#  else
#    if defined(XP_UNIX) || defined(XP_BEOS)
#      define NS_LINEBREAK         "\012"
#      define NS_LINEBREAK_LEN     1
#    endif /* XP_UNIX */
#  endif /* XP_PC */
#endif /* XP_MAC */

from msgcore.h:
#define MSG_LINEBREAK NS_LINEBREAK
#define MSG_LINEBREAK_LEN NS_LINEBREAK_LEN

VERIFIED

Comment 8

[Pulsebot]

Pushed by ffxbld-merge:
https://hg.mozilla.org/releases/mozilla-beta/rev/6ecfa473aba0
[fenix] For https://github.com/mozilla-mobile/fenix/issues/15291 - Limit current CFRs to show max one every 3 days