1529105 - Compile warning in OpenVRSession.cpp: the use of `tmpnam' is dangerous

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

The following warnings are shown after linking libxul.so.

 0:09.42 toolkit/library/libxul.so
 0:28.59 /home/tlin/Projects/gecko/gfx/vr/service/OpenVRSession.cpp:285: warning: the use of `tmpnam' is dangerous, better use `mkstemp'
 0:28.59 /home/tlin/Projects/gecko/gfx/vr/service/OpenVRSession.cpp:292: warning: the use of `tmpnam' is dangerous, better use `mkstemp'
 0:28.59 /home/tlin/Projects/gecko/gfx/vr/service/OpenVRSession.cpp:324: warning: the use of `tmpnam' is dangerous, better use `mkstemp'
 0:28.59 /home/tlin/Projects/gecko/gfx/vr/service/OpenVRSession.cpp:341: warning: the use of `tmpnam' is dangerous, better use `mkstemp'
 0:28.59 /home/tlin/Projects/gecko/gfx/vr/service/OpenVRSession.cpp:352: warning: the use of `tmpnam' is dangerous, better use `mkstemp'
 0:28.59 /home/tlin/Projects/gecko/gfx/vr/service/OpenVRSession.cpp:369: warning: the use of `tmpnam' is dangerous, better use `mkstemp'
 0:38.59 toolkit/library/dependentlibs.list.stub

FWIW, I compile on Linux using clang version clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final), and the following in my mozconfig.

ac_add_options --enable-debug
ac_add_options --disable-optimize

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

If it's intentional to use std::tmpnam(nullptr), maybe we should silence the warnings?

Comment 2

[Daosheng Mu[:daoshengmu]]

Thanks, TYLin.

I think we should replace std::tmpnam with std::tmpnam_s. I will work on this shortly.

Comment 3

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1529105 - Replace tmpname with tmpname_s in OpenVRSession.

Comment 4

[Daosheng Mu[:daoshengmu]]

we will target it to FF 68.

Comment 6

[Frederik Braun [:freddy]]

daoshengmu, the patch does not have any reviewers. Do you consider it finished?

Comment 7

[Daosheng Mu[:daoshengmu]]

(In reply to Frederik Braun [:freddyb] from comment #6)

daoshengmu, the patch does not have any reviewers. Do you consider it finished?

I haven't done it yet but close. I will continue to work on this this week.

Comment 8

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1529105 - Replace tmpname in OpenVRSession when using action input.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb714fa13ef9
Replace tmpname in OpenVRSession when using action input. r=kip

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/bb714fa13ef9