1529139 - win64 aarch64 artifact builds busted after bug 1527471

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

13:08:29     INFO -  z:/task_1550579494/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.file_generate z:/task_1550579494/build/src/xpcom/reflect/xptcall/md/win32/preprocess.py preprocess xptcstubs.asm .deps/xptcstubs.asm.pp .deps/xptcstubs.asm.stub z:/task_1550579494/build/src/xpcom/reflect/xptcall/md/win32/xptcstubs_asm_aarch64.asm
13:08:29    ERROR -  Traceback (most recent call last):
13:08:29     INFO -    File "c:\mozilla-build\python\Lib\runpy.py", line 174, in _run_module_as_main
13:08:29     INFO -      "__main__", fname, loader, pkg_name)
13:08:29     INFO -    File "c:\mozilla-build\python\Lib\runpy.py", line 72, in _run_code
13:08:29     INFO -      exec code in run_globals
13:08:29     INFO -    File "z:\task_1550579494\build\src\python\mozbuild\mozbuild\action\file_generate.py", line 120, in <module>
13:08:29     INFO -      sys.exit(main(sys.argv[1:]))
13:08:29     INFO -    File "z:\task_1550579494\build\src\python\mozbuild\mozbuild\action\file_generate.py", line 71, in main
13:08:29     INFO -      ret = module.__dict__[method](output, *args.additional_arguments, **kwargs)
13:08:29     INFO -    File "z:/task_1550579494/build/src/xpcom/reflect/xptcall/md/win32/preprocess.py", line 18, in preprocess
13:08:29     INFO -      if not os.path.exists(cxx[0]):
13:08:29     INFO -  IndexError: list index out of range
13:08:29     INFO -  backend.mk:20: recipe for target '.deps/xptcstubs.asm.stub' failed
13:08:29     INFO -  mozmake.EXE[4]: *** [.deps/xptcstubs.asm.stub] Error 1

The problem is the build system doesn't know not to build generated_file targets that are compilation sources.

Comment 1

[Mike Hommey [:glandium]]

The problem is the build system doesn't know not to build generated_file targets that are compilation sources.

aha! it does, but not for these files!

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1529139 - Mark .asm GENERATED_FILES as required_for_compile.

This will avoid trying to generate them during artifact builds.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88a27dc859b9
Mark .asm GENERATED_FILES as required_for_compile. r=froydnj

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for bustage due to missing fficonfig.h

backout: https://hg.mozilla.org/integration/autoland/rev/d0d59b7817be84b325ed61dee7f4684c31a0d41e

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=229408877&revision=88a27dc859b9e45ae9510c4c20822bf6d085d5f5&searchStr=br

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=229409130&repo=autoland&lineNumber=1590

/ipc/PPrintSettingsDialog.ipdl z:/build/build/src/toolkit/components/printingui/ipc/PPrinting.ipdl z:/build/build/src/toolkit/components/printingui/ipc/PPrintingTypes.ipdlh z:/build/build/src/tools/profiler/gecko/PProfiler.ipdl z:/build/build/src/tools/profiler/gecko/ProfilerTypes.ipdlh z:/build/build/src/uriloader/exthandler/PExternalHelperApp.ipdl z:/build/build/src/uriloader/exthandler/PHandlerService.ipdl z:/build/build/src/uriloader/prefetch/POfflineCacheUpdate.ipdl z:/build/build/src/widget/headless/HeadlessWidgetTypes.ipdlh z:/build/build/src/widget/windows/PCompositorWidget.ipdl z:/build/build/src/widget/windows/PlatformWidgetTypes.ipdlh
12:00:55 INFO - ../../../../js/src/ctypes/libffi/src/x86/win32.S(33,10): fatal error: 'fficonfig.h' file not found
12:00:55 INFO - #include <fficonfig.h>
12:00:55 INFO - ^~~~~~~~~~~~~
12:00:55 INFO - 1 error generated.
12:00:55 INFO - z:/build/build/src/sccache2/sccache.exe z:/build/build/src/clang/bin/clang-cl.exe -E -Xclang -std=gnu99 -m32 -EP -DNDEBUG=1 -DTRIMMED=1 -DTARGET=X86_WIN32 -DFFI_NO_RAW_API -DX86_WIN32 -DHAVE_AS_STRING_PSEUDO_OP -DHAVE_AS_X86_64_UNWIND_SECTION_TYPE -DHAVE_AS_ASCII_PSEUDO_OP -DHAVE_AS_X86_PCREL -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -Iz:/build/build/src/obj-firefox/js/src/ctypes/libffi -Iz:/build/build/src/obj-firefox/js/src/ctypes/libffi/include -Iz:/build/build/src/js/src/ctypes/libffi/include -Iz:/build/build/src/js/src/ctypes/libffi/src/x86 ../../../../js/src/ctypes/libffi/src/x86/win32.S
12:00:55 INFO - z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.file_generate z:/build/build/src/security/ct/tests/gtest/createSTHTestData.py main valid-with-extension-sth.inc .deps/valid-with-extension-sth.inc.pp .deps/valid-with-extension-sth.inc.stub z:/build/build/src/security/ct/tests/gtest/valid-with-extension-sth.inc.tbs
12:00:55 INFO - z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.file_generate z:/build/build/src/security/apps/gen_cert_header.py addonsPublicRoot addons-public.inc .deps/addons-public.inc.pp .deps/addons-public.inc.stub z:/build/build/src/security/apps/addons-public.crt
12:00:55 INFO - security/ct/tests/gtest/valid-secp521r1-sha512-sth.inc.stub
12:00:55 INFO - security/apps/addons-stage.inc.stub
12:00:55 INFO - z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe z:/build/build/src/config/nsinstall.py -R -m 644 'xpcom-config.h' '../dist/include'
12:00:55 ERROR - Traceback (most recent call last):
12:00:55 INFO - File "c:\mozilla-build\python\Lib\runpy.py", line 174, in _run_module_as_main
12:00:55 INFO - "main", fname, loader, pkg_name)
12:00:55 INFO - File "c:\mozilla-build\python\Lib\runpy.py", line 72, in _run_code
12:00:55 INFO - exec code in run_globals
12:00:55 INFO - File "z:\build\build\src\python\mozbuild\mozbuild\action\file_generate.py", line 120, in <module>
12:00:55 INFO - sys.exit(main(sys.argv[1:]))
12:00:55 INFO - File "z:\build\build\src\python\mozbuild\mozbuild\action\file_generate.py", line 71, in main
12:00:55 INFO - ret = module.dict[method](output, *args.additional_arguments, **kwargs)
12:00:55 INFO - File "z:/build/build/src/config/external/ffi/preprocess_libffi_asm.py", line 23, in main
12:00:55 INFO - preprocessed = subprocess.check_output(args)
12:00:55 INFO - File "c:\mozilla-build\python\Lib\subprocess.py", line 223, in check_output
12:00:55 INFO - raise CalledProcessError(retcode, cmd, output=output)
12:00:55 INFO - subprocess.CalledProcessError: Command '[u'z:/build/build/src/sccache2/sccache.exe', u'z:/build/build/src/clang/bin/clang-cl.exe', u'-E', u'-Xclang', u'-std=gnu99', u'-m32', '-EP', '-DNDEBUG=1', '-DTRIMMED=1', '-DTARGET=X86_WIN32', '-DFFI_NO_RAW_API', '-DX86_WIN32', '-DHAVE_AS_STRING_PSEUDO_OP', '-DHAVE_AS_X86_64_UNWIND_SECTION_TYPE', '-DHAVE_AS_ASCII_PSEUDO_OP', '-DHAVE_AS_X86_PCREL', '-DEXPORT_JS_API', '-DMOZ_HAS_MOZGLUE', '-Iz:/build/build/src/obj-firefox/js/src/ctypes/libffi', '-Iz:/build/build/src/obj-firefox/js/src/ctypes/libffi/include', '-Iz:/build/build/src/js/src/ctypes/libffi/include', '-Iz:/build/build/src/js/src/ctypes/libffi/src/x86', '../../../../js/src/ctypes/libffi/src/x86/win32.S']' returned non-zero exit status 1
12:00:55 INFO - z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.file_generate z:/build/build/src/security/ct/tests/gtest/createSTHTestData.py main valid-secp521r1-sha512-sth.inc .deps/valid-secp521r1-sha512-sth.inc.pp .deps/valid-secp521r1-sha512-sth.inc.stub z:/build/build/src/security/ct/tests/gtest/valid-secp521r1-sha512-sth.inc.tbs
12:00:55 INFO - backend.mk:30: recipe for target '.deps/win32.asm.stub' failed
12:00:55 INFO - mozmake.EXE[2]: *** [.deps/win32.asm.stub] Error 1

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1529139 - Add proper dependencies for win{32,64}.asm.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4767ef1dd263
Add proper dependencies for win{32,64}.asm. r=froydnj
https://hg.mozilla.org/integration/autoland/rev/1467e281ab6c
Mark .asm GENERATED_FILES as required_for_compile. r=froydnj

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/4767ef1dd263
https://hg.mozilla.org/mozilla-central/rev/1467e281ab6c

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request uplift here too (for bug 1527471)? Thanks.

Comment 9

[Mike Hommey [:glandium]]

Comment on attachment 9045474 [details]
Bug 1529139 - Add proper dependencies for win{32,64}.asm.

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1527471

User impact if declined

Artifact builds busted after bug 1527471

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Build system change only. It either builds or doesn't, and it does :)

String changes made/needed

N/A

Comment 10

[Mike Hommey [:glandium]]

Comment on attachment 9045137 [details]
Bug 1529139 - Mark .asm GENERATED_FILES as required_for_compile.

Beta/Release Uplift Approval Request

Feature/Bug causing the regression

Bug 1527471

User impact if declined

Artifact builds busted

Is this code covered by automated tests?

No

Has the fix been verified in Nightly?

Yes

Needs manual test from QE?

No

If yes, steps to reproduce

List of other uplifts needed

None

Risk to taking this patch

Low

Why is the change risky/not risky? (and alternatives if risky)

Same as the other patch.

String changes made/needed

N/A

Comment 11

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9045137 [details]
Bug 1529139 - Mark .asm GENERATED_FILES as required_for_compile.

Keep artifact builds building.
OK for beta uplift.

Comment 12

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c636ac25be61

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9045474 [details]
Bug 1529139 - Add proper dependencies for win{32,64}.asm.

[Triage Comment] this is needed on beta to fix build bustage

Comment 14

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/53e4e8116497
https://hg.mozilla.org/releases/mozilla-beta/rev/d1f8173046a0