1529164 - Remove Fake Plugin handling from nsFrameLoader

Status: RESOLVED FIXED

(Core :: DOM: Navigation, enhancement, P3)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Since we no longer seem to use fake plugins anywhere, we can remove handling of their frame creation from nsFrameLoader. One less thing to worry about during the nsFrameLoaderOwner refactor.

For now, this replaces any use of ObjectLoadingContent for FakePlugins with a crash, which seems like it should get people's attention.

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1529164 - Remove FakePlugin frame loading;

Remove the ability for fake plugins to create frames. Fake plugins
aren't used anymore, so we can simplify nsFrameLoader a bit by
removing some of the related checks.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=968796152848863996f0ade7f46c011358e72ff4

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd5fbc5d0466
Remove FakePlugin frame loading; r=nika

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/bd5fbc5d0466

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/bd5fbc5d0466