1529195 - Add some flexibility to the mach artifact install command

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

and various cleanups.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1529195 - Remove artifact filters for firefox-* and fennec-*.

The filters were added back when buildbot was still used, and some
artifacts were still using file names beginning with "firefox" or
"fennec".
That is not true now that all builds are on taskcluster, and for all of
them, they are now target.$ext.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Bug 1529195 - Remove per-job tests regexp definition.

Once the firefox-* and fennec-* regexp are gone, we come to realize
that all jobs have the same regexp for tests, so we can just
use that across the board and remove the definition from JOB_DETAILS.

Depends on D20441

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1529195 - Move per-job package regexp to per-platform.

Once all tests regexp are gone, we come to realize that all the package
regexp are the same for each ArtifactJob subclass, some we move the
definitions to the subclasses.

Depends on D20442

Comment 4

[Mike Hommey [:glandium]]

Attachment: Bug 1529195 - Cache list of artifacts and task id for a given set of (tree, job, rev).

Instead of having cache misses for all variables that may vary when
getting job details. While the currently used variables are mostly
constants, we're going to introduce some flexibility in an subsequent
change.

Depends on D20443

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1529195 - Remove the get_job_details function.

It is now not useful to keep as a separate function.

Depends on D20444

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1529195 - Allow to opt-in to symbols/host-bin artifacts from the CLI.

and to opt-out of test artifacts.

Depends on D20445

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1529195 - Allow to pass a different directory than $DIST to install artifacts to.

Depends on D20446

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd0887190430
Remove artifact filters for firefox-* and fennec-*. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/8f52eac86c83
Remove per-job tests regexp definition. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/70d73ba56f65
Move per-job package regexp to per-platform. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/b151215219e9
Cache list of artifacts and task id for a given set of (tree, job, rev). r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/e953a0b9aefc
Remove the get_job_details function. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/b78a6ad317cf
Allow to opt-in to symbols/host-bin artifacts from the CLI. r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/4e79e369f1ee
Allow to pass a different directory than $DIST to install artifacts to. r=chmanchester

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cd0887190430
https://hg.mozilla.org/mozilla-central/rev/8f52eac86c83
https://hg.mozilla.org/mozilla-central/rev/70d73ba56f65
https://hg.mozilla.org/mozilla-central/rev/b151215219e9
https://hg.mozilla.org/mozilla-central/rev/e953a0b9aefc
https://hg.mozilla.org/mozilla-central/rev/b78a6ad317cf
https://hg.mozilla.org/mozilla-central/rev/4e79e369f1ee