[wpt-sync] Sync PR 14804 - Enforce active lifetime of XRFrame objects
Categories
(Testing :: web-platform-tests, enhancement, P4)
Tracking
(firefox67 fixed)
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: wptsync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14804 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/14804
Details from upstream follow.
Brandon Jones <bajones@chromium.org> wrote:
Enforce active lifetime of XRFrame objects
Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1343065
Incorporates fixes made by jacde@chromium.org (Thanks!)Deactivates XRFrame objects once the relevant callback returns, which
causes future calls to the object methods to throw an exception.Bug: 906842
Change-Id: Ib635f56ed28b728434a08347b9d9fb98d1ecd694
Reviewed-on: https://chromium-review.googlesource.com/1363836
WPT-Export-Revision: 192a682c75ec0ec825140012cee26edcf4182ddd
|
Assignee | |
Comment 1•7 months ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=04b2f85c5440965e855860c4e75a09d680695ee1
|
|
Assignee | |
Comment 2•7 months ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=77a7f0e156fa509249ecba5c3eb5b97c03393700
|
|
Assignee | |
Comment 3•7 months ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=799bec10e2a2300333117613a9220f25a47dbd74
|
|
Assignee | |
Comment 4•7 months ago
|
||
Ran 1 tests and 2 subtests
OK : 1
FAIL : 2
New tests that have failures or other problems:
/webxr/xrFrame_lifetime.https.html
XRFrame methods throw exceptions outside of the requestAnimationFrame callback for immersive sessions: FAIL
XRFrame methods throw exceptions outside of the requestAnimationFrame callback for non-immersive sessions: FAIL
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/37d25235012d [wpt PR 14804] - Enforce active lifetime of XRFrame objects, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/719455274599 [wpt PR 14804] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/1244fe26b18d [wpt PR 14804] - Enforce active lifetime of XRFrame objects, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/e61e1c0300f2 [wpt PR 14804] - Update wpt metadata, a=testonly
|
||
Comment 7•6 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1244fe26b18d
https://hg.mozilla.org/mozilla-central/rev/e61e1c0300f2
Description
•