Closed Bug 1529206 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 14804 - Enforce active lifetime of XRFrame objects

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox67 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 14804 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14804
Details from upstream follow.

Brandon Jones <bajones@chromium.org> wrote:

Enforce active lifetime of XRFrame objects

Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1343065
Incorporates fixes made by jacde@chromium.org (Thanks!)

Deactivates XRFrame objects once the relevant callback returns, which
causes future calls to the object methods to throw an exception.

Bug: 906842
Change-Id: Ib635f56ed28b728434a08347b9d9fb98d1ecd694
Reviewed-on: https://chromium-review.googlesource.com/1363836
WPT-Export-Revision: 192a682c75ec0ec825140012cee26edcf4182ddd

Ran 1 tests and 2 subtests OK : 1 FAIL : 2 New tests that have failures or other problems: /webxr/xrFrame_lifetime.https.html XRFrame methods throw exceptions outside of the requestAnimationFrame callback for immersive sessions: FAIL XRFrame methods throw exceptions outside of the requestAnimationFrame callback for non-immersive sessions: FAIL
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/37d25235012d [wpt PR 14804] - Enforce active lifetime of XRFrame objects, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/719455274599 [wpt PR 14804] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/1244fe26b18d [wpt PR 14804] - Enforce active lifetime of XRFrame objects, a=testonly https://hg.mozilla.org/integration/mozilla-inbound/rev/e61e1c0300f2 [wpt PR 14804] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/1244fe26b18d
https://hg.mozilla.org/mozilla-central/rev/e61e1c0300f2

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.