Closed Bug 1529247 Opened 6 years ago Closed 6 years ago

Remove unused ThreadClient Methods

Tracking

(Not tracked)

Status:

RESOLVED FIXED

People

(Reporter: yulia, Assigned: yulia)

References

Details

(Whiteboard: dt-fission)

Attachments

(8 files, 1 obsolete file)

Bug 1529247 - Remove environment method from the threadClient; r=ochameau 6 years ago Yulia Startsev [:yulia] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1529247 - clean up frame scripts methods; r=ochameau 6 years ago Yulia Startsev [:yulia] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1529247 - clean up frames methods on thread client; r=ochameau 6 years ago Yulia Startsev [:yulia] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1529247 - remove unused getPrototypesAndProperties method; r=ochameau 6 years ago Yulia Startsev [:yulia] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1529247 - remove unused cachedScript property; r=ochameau 6 years ago Yulia Startsev [:yulia] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1529247 - remove unused releaseMany method from thread client and actor; r=ochameau 6 years ago Yulia Startsev [:yulia] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1529247 - remove unused eval method from threadClient and threadActor; r=ochameau 6 years ago Yulia Startsev [:yulia] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1529247 - remove unused eventlisteners method; r=ochameau 6 years ago Yulia Startsev [:yulia] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1529247 - remove unused pausedLongString method, threadLongString and arrayBuffer methods; r=ochameau 6 years ago Yulia Startsev [:yulia] 47 bytes, text/x-phabricator-request		Details \| Review

Yulia Startsev [:yulia]

Assignee

Description

•

6 years ago

There are a number of methods that are hold overs from the old debugger that should be cleaned up before we move towards transforming the ThreadClient into a protocol.js front.

Yulia Startsev [:yulia]

Assignee

Updated

•

6 years ago

Keywords: leave-open

Yulia Startsev [:yulia]

Assignee

Comment 1

•

6 years ago

Attached file Bug 1529247 - Remove environment method from the threadClient; r=ochameau — Details

Yulia Startsev [:yulia]

Assignee

Comment 2

•

6 years ago

Attached file Bug 1529247 - clean up frame scripts methods; r=ochameau — Details

these events no longer exist

Yulia Startsev [:yulia]

Assignee

Comment 3

•

6 years ago

Attached file Bug 1529247 - clean up frames methods on thread client; r=ochameau — Details

Yulia Startsev [:yulia]

Assignee

Comment 4

•

6 years ago

Attached file Bug 1529247 - remove unused getPrototypesAndProperties method; r=ochameau — Details

Pulsebot

Comment 5

•

6 years ago

Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8dc367557c04 clean up frame scripts methods; r=ochameau

Pulsebot

Comment 6

•

6 years ago

Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/49828e666e4d Remove environment method from the threadClient; r=ochameau

Razvan Maries

Comment 7

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/8dc367557c04
https://hg.mozilla.org/mozilla-central/rev/49828e666e4d

Razvan Maries

Comment 8

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/8dc367557c04
https://hg.mozilla.org/mozilla-central/rev/49828e666e4d

Pulsebot

Comment 9

•

6 years ago

Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/601742636bd1 remove unused getPrototypesAndProperties method; r=ochameau

Natalia Csoregi [:nataliaCs]

Comment 10

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/601742636bd1

Jason Laster [:jlast]

Updated

•

6 years ago

Priority: -- → P2

Yulia Startsev [:yulia]

Assignee

Comment 11

•

6 years ago

Attached file Bug 1529247 - remove unused cachedScript property; r=ochameau — Details

Yulia Startsev [:yulia]

Assignee

Comment 12

•

6 years ago

Attached file Bug 1529247 - remove unused releaseMany method from thread client and actor; r=ochameau — Details

There is one spot I am unsure about, and that is the test:
devtools/server/tests/unit/test_threadlifetime-06.js -- should this be kept or do we want to remove
it as well?

Yulia Startsev [:yulia]

Assignee

Comment 13

•

6 years ago

Attached file Bug 1529247 - remove unused eval method from threadClient and threadActor; r=ochameau (obsolete) — Details

Yulia Startsev [:yulia]

Assignee

Comment 14

•

6 years ago

Attached file Bug 1529247 - remove unused eventlisteners method; r=ochameau — Details

Yulia Startsev [:yulia]

Assignee

Comment 15

•

6 years ago

Attached file Bug 1529247 - remove unused pausedLongString method, threadLongString and arrayBuffer methods; r=ochameau — Details

Pulsebot

Comment 16

•

6 years ago

Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ff07a2a59bb0 clean up frames methods on thread client; r=ochameau

Razvan Maries

Comment 17

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/ff07a2a59bb0

Phabricator Automation

Comment 18

•

6 years ago

Comment on attachment 9047709 [details]
Bug 1529247 - remove unused eval method from threadClient and threadActor; r=ochameau

Revision D21700 was moved to bug 1532567. Setting attachment 9047709 [details] to obsolete.

Attachment #9047709 - Attachment is obsolete: true

Pulsebot

Comment 19

•

6 years ago

Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eff76a5ca4f8 remove unused eventlisteners method; r=ochameau

Stefan Hindli [:stefan_hindli]

Comment 20

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/eff76a5ca4f8

Alexandre Poirot [:ochameau]

Updated

•

6 years ago

Depends on: 1528986

Alexandre Poirot [:ochameau]

Updated

•

6 years ago

No longer depends on: 1528986

Narcis Beleuzu [:NarcisB]

Comment 21

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/aa554fe5d8fe
https://hg.mozilla.org/mozilla-central/rev/4cb9ab350bcb

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Comment 22

•

6 years ago

https://hg.mozilla.org/integration/autoland/rev/aa554fe5d8fe9c2392b1d3daaa2757d2763636d1
https://hg.mozilla.org/integration/autoland/rev/4cb9ab350bcb8afdee1b27aa970e75a8577d7bd9

Phabricator Automation

Updated

•

6 years ago

Attachment #9047737 - Attachment description: Bug 1529247 - remove unused pausedLongString method and sustitute it with threadLongString method; r=ochameau → Bug 1529247 - remove unused pausedLongString method, threadLongString method and arrayBuffer method from threadclient; r=ochameau

Phabricator Automation

Updated

•

6 years ago

Attachment #9047737 - Attachment description: Bug 1529247 - remove unused pausedLongString method, threadLongString method and arrayBuffer method from threadclient; r=ochameau → Bug 1529247 - remove unused pausedLongString method and sustitute it with threadLongString method; r=ochameau

Phabricator Automation

Updated

•

6 years ago

Pulsebot

Comment 23

•

6 years ago

Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05e9997b6809 remove unused pausedLongString method, threadLongString and arrayBuffer methods; r=ochameau

Cristina Coroiu [:ccoroiu]

Comment 24

•

6 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/05e9997b6809

Jason Laster [:jlast]

Comment 25

•

6 years ago

Is this done yulia?

Flags: needinfo?(ystartsev)

Yulia Startsev [:yulia]

Assignee

Comment 26

•

6 years ago

Looks like it is done -- I thought there was still some work to do on updatedSource but it looks like that was done already.

Status: NEW → RESOLVED

Closed: 6 years ago

Flags: needinfo?(ystartsev)

Resolution: --- → FIXED

BugBot [:suhaib / :marco/ :calixte]

Updated

•

6 years ago

Keywords: leave-open

You need to log in before you can comment on or make changes to this bug.