Closed
Bug 1529294
Opened 7 years ago
Closed 7 years ago
Add a test for ArrayBuffers with external contents not being serializable
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: Waldo, Assigned: Waldo)
Details
Attachments
(1 file)
|
6.62 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
I thought based on code inspection this was Problematic, then I tried it out and found out about the preflight-the-graph that weeds out these sorts of buffers already when I wrote this test.
But hey, this test seems useful to actually exercise an edge case -- why not land it?
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #9045257 -
Flags: review?(sphink)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 9045257 [details] [diff] [review]
Patch
Review of attachment 9045257 [details] [diff] [review]:
-----------------------------------------------------------------
That is a remarkably complete exercise of that particular codepath.
Attachment #9045257 -
Flags: review?(sphink) → review+
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/086f0ad27487
Add a test for ArrayBuffers with external contents not being serializable. r=sfink
Pushed by jwalden@mit.edu:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9cb1a38c00ed
Add a test for ArrayBuffers with external contents not being serializable. r=sfink
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•