Closed Bug 1529308 Opened 7 years ago Closed 7 years ago

Use a new comm_client flag in nss.gyp, which enables TB to build cmsutil

Categories

(NSS :: Tools, enhancement)

Product:
NSS
Component:
Tools
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: KaiE, Assigned: KaiE)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

1529308-v2.patch
1.58 KB, patch
jcj
: review+
Details | Diff | Splinter Review
fix-1529308.patch
773 bytes, patch
jcj
: review+
Details | Diff | Splinter Review

Thunderbird wants to implement automated testing for S/MIME messages.
(NSS only tests the CMS message blobs, but doesn't test CMS with MIME.)

Thunderbird requires cmsutil to create test messages during the build.

Could we please build cmsutil when building the Mozilla clients?

Attached patch 1529308-v1.patch (obsolete) — — Splinter Review
Attachment #9045312 - Flags: review?(jjones)

Note this change will make cmsutil available in obj/dist/bin of a firefox/thunderbird, but it shouldn't influence packaging/distribution.

Comment on attachment 9045312 [details] [diff] [review] 1529308-v1.patch Review of attachment 9045312 [details] [diff] [review]: ----------------------------------------------------------------- Seems fine to me. r=jcj
Attachment #9045312 - Flags: review?(jjones) → review+

Thanks J.C.

https://hg.mozilla.org/projects/nss/rev/d734d20b38d8

Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.43

Backed out changeset d734d20b38d8 for undefined symbol m-c failures on MacOS and Android.

https://hg.mozilla.org/projects/nss/rev/f7be0a534e89f5b8c67a8cf1f7931f8f8801fbd1

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Depends on: 1530671
Attached patch 1529308-v2.patch — — Splinter Review

Alternative approach.

Requires the changes from bug 1530671.

Attachment #9045312 - Attachment is obsolete: true
Attachment #9046688 - Flags: review?(jjones)
Comment on attachment 9046688 [details] [diff] [review] 1529308-v2.patch Review of attachment 9046688 [details] [diff] [review]: ----------------------------------------------------------------- OK, looks right. Separate landings, one patch. :)
Attachment #9046688 - Flags: review?(jjones) → review+
Summary: Build cmsutil for Thunderbird → Use a new comm_client flag to the NSS gyp build, which enables TB to build cmsutil
Summary: Use a new comm_client flag to the NSS gyp build, which enables TB to build cmsutil → Use a new comm_client flag in nss.gyp, which enables TB to build cmsutil

https://hg.mozilla.org/projects/nss/rev/68578ca0ba17f205e4f92512157368eaf1694eb3

Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Blocks: 1532626

I had checked in an incorrect patch. This incremental patch fixes it to the reviewed version.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: