1529360 - Pushing to try via cinnabar has started bundling ~4400 changesets, taking a long time

Status: RESOLVED INVALID

(Developer Infrastructure :: Try, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

In the last day or two sometime doing pushes to try either via ./mach try or even just a git push try has started to take a very long time, as it bundles up ~4434 changesets and manifests for no obvious reason.

This happened to me this morning (after a couple of aborted attempts I let it finish which took a while but resulted in this try push). And then on IRC :eoger also reported seeing the same thing. I tried re-pushing (via ./mach try) the same revision as the above try push, and again it started to bundle up the 4k+ changesets. So it doesn't seem like a case where the changesets are just missing from try and the first person to do the push gets stuck with the bill. Rather it seems to be impacting every push as far as I can tell.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Pushing with -n completes quickly:

$ time git push -n -vv try
Pushing to hg::ssh://hg.mozilla.org/try
To hg::ssh://hg.mozilla.org/try
 + 6bed605c756d...2703b211b6c0 HEAD -> branches/default/tip (forced update)

real	0m19.494s
user	0m14.480s
sys	0m1.484s

Same thing without -n starts the long bundling process. Note that 6bed605c756d is some revision from september 2018 (seems to be esr52 tip) so presumably related?

Also, the try section in my gitconfig is:

[remote "try"]
    url = hg::https://hg.mozilla.org/try
    fetch = +refs/heads/*:refs/remotes/try/*
    skipDefaultUpdate = true
    pushurl = hg::ssh://hg.mozilla.org/try
    push = +HEAD:refs/heads/branches/default/tip

Comment 2

[Mike Hommey [:glandium]]

Note that 6bed605c756d is some revision from september 2018 (seems to be esr52 tip) so presumably related?

probably not. That's just what happens to have been the tip of try when you tried, and that's not relevant to the actual push. That just tells you what the ref you're pushing to (branches/default/tip) was before you update it.

There is a longstanding known issue that makes git find more than there is to find, and there's not much we can do to work around. If this is what you're hitting, rebasing to some other commit from central or an integration branch will solve it.

See http://public-inbox.org/git/[e-mail]/

In any case, this isn't something that can be addressed here. Now that cinnabar uses its helper for more things, that /might/ be fixable in cinnabar without having to wait for some workaround in git. Worth opening an issue on https://github.com/glandium/git-cinnabar/issues.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Indeed, updating to a new base rev made the problem go away. Thanks!

Comment 4

[Mike Hommey [:glandium]]

As of https://github.com/glandium/git-cinnabar/commit/28e37508416449da0e235b93d5fcc3b79090a2f3 , this shouldn't happen anymore.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Thanks!