1529394 - pref on the incognito feature

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Shane Caraveo (:mixedpuppy)]

Might be a touch more than just a pref update, have to run all tests through to ensure any that use private windows continue to work.

Comment 1

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e8cc05444b5a9f87fa896e93cbd847162d2bb05

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1529394 fix tests for pref'ing on incognito not_allowed

This patch addresses remaining test issues when pref'ing on. These are tests that
previously ran some tests in private contexts that now require the use of incognitoOverride.
This also fixes an xpcshell test wrapper to set the permission when overridden.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1529394 pref 'on' incognito not_allowed

Comment 4

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6bb53a5fccc0b4c9c1bed64bcb574aea657c6681

Comment 5

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5049119648d34cbcb0357213acdc50b0188e2e8

Comment 6

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b3e37920441149b4c9551eccab4b6812678a1421

Comment 7

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4854ff9dc982a05272377689b97c792b47f96f85

Comment 8

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=41529c6187d9be9c9c4a5b815e6833aace4d37ac

Comment 9

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=033d7030193c1454abb9536762adcc91ee37e6d5

Comment 10

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f00fe7b77c4da6718d00602d39ea024eb423904c

Comment 11

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=da2d32f03b5d92c18f98a77524167a6076a8c3c4

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a8c338af709
fix tests for pref'ing on incognito not_allowed r=rpl
https://hg.mozilla.org/integration/autoland/rev/7f3e254c982c
pref 'on' incognito not_allowed r=kmag

Comment 13

[Andreea Pavel [:apavel]]

Backed out for failing bc at automation.py

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=7f3e254c982c86371a0dc92a78c929b9cabbc3c1&selectedJob=231749685

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=231749685&repo=autoland&lineNumber=2230

Backout: https://hg.mozilla.org/integration/autoland/rev/f324b0fe247192d8f1a3cad23b84e2e16a56249c

Comment 14

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=26409f4e4bccef225ecad17d2e48a3ccea8a72a8

Comment 15

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7760f55207b5489082287dac4b79ed77fade9f15

Comment 16

[Pascal Chevrel:pascalc]

Tracking for 67, this will probably require an addition to our release notes.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f4cf036e591
fix tests for pref'ing on incognito not_allowed r=rpl

Comment 18

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=61a3c45a42a9ea2f68c1e9470c81027705ec4ef6

Comment 19

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1529394 revert early breakout to support test infra extensions

Comment 20

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9f4cf036e591

Comment 21

[Shane Caraveo (:mixedpuppy)]

Two more patches to land.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53ac343019c6
revert early breakout to support test infra extensions r=rpl
https://hg.mozilla.org/integration/autoland/rev/095dde8fb209
pref 'on' incognito not_allowed r=kmag

Comment 23

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/53ac343019c6
https://hg.mozilla.org/mozilla-central/rev/095dde8fb209

Comment 24

[CosminB]

Attachment: Bug1529394.gif

The preference “extensions.allowPrivateBrowsingByDefault” is set to false by default.

With the preference set to false by default, the extensions need to be allowed to work in private windows.

Please see the attached video.

Comment 25

[CosminB]

This issue is verified as fixed on Firefox 67.0a1 (20190306161300) under Win 7 64-bit and Mac OS X 10.14.1.