pref on the incognito feature

VERIFIED FIXED in Firefox 67

Status

enhancement
P1
normal
VERIFIED FIXED
4 months ago
3 months ago

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

Tracking

(Blocks 2 bugs)

unspecified
mozilla67
Dependency tree / graph

Firefox Tracking Flags

(firefox65 unaffected, firefox66 unaffected, firefox67+ verified)

Details

Attachments

(4 attachments)

Assignee

Description

4 months ago

Might be a touch more than just a pref update, have to run all tests through to ensure any that use private windows continue to work.

Assignee

Comment 2

4 months ago

This patch addresses remaining test issues when pref'ing on. These are tests that
previously ran some tests in private contexts that now require the use of incognitoOverride.
This also fixes an xpcshell test wrapper to set the permission when overridden.

Comment 12

4 months ago
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a8c338af709
fix tests for pref'ing on incognito not_allowed r=rpl
https://hg.mozilla.org/integration/autoland/rev/7f3e254c982c
pref 'on' incognito not_allowed r=kmag

Tracking for 67, this will probably require an addition to our release notes.

Comment 17

4 months ago
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f4cf036e591
fix tests for pref'ing on incognito not_allowed r=rpl
Assignee

Updated

4 months ago
Blocks: 1532774

Comment 20

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Assignee

Comment 21

4 months ago

Two more patches to land.

Status: RESOLVED → REOPENED
Flags: needinfo?(mixedpuppy)
Resolution: FIXED → ---

Comment 22

4 months ago
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/53ac343019c6
revert early breakout to support test infra extensions r=rpl
https://hg.mozilla.org/integration/autoland/rev/095dde8fb209
pref 'on' incognito not_allowed r=kmag

Comment 23

4 months ago
bugherder
Status: REOPENED → RESOLVED
Closed: 4 months ago4 months ago
Resolution: --- → FIXED

Comment 24

4 months ago
Posted image Bug1529394.gif

The preference “extensions.allowPrivateBrowsingByDefault” is set to false by default.

With the preference set to false by default, the extensions need to be allowed to work in private windows.

Please see the attached video.

Comment 25

4 months ago

This issue is verified as fixed on Firefox 67.0a1 (20190306161300) under Win 7 64-bit and Mac OS X 10.14.1.

Status: RESOLVED → VERIFIED

Updated

3 months ago
Regressions: 1541827
You need to log in before you can comment on or make changes to this bug.