1529411 - onRemoved for last tab dispatched before onCreated with browser.tabs.closeWindowWithLastTab=false

Status: REOPENED

(WebExtensions :: Frontend, defect, P3)

Description

[Oriol Brufau [:Oriol]]

1. Set browser.tabs.closeWindowWithLastTab=false
2. Let a window have 1 tab
3. Close the tab
4. browser.tabs.onRemoved fires earlier than browser.tabs.onCreated

This is bad because:

• Can make extensions think the number of tabs has reached 0 and the window is closing
• Does not reflect internal reality. "TabOpen" is dispatched earlier than "TabClose". If you check gBrowser.tabs.length, it increases from 1 to 2 and then goes back to 1. But what webextensions detect is 1 decreasing to 0 and going back to 1.

This is a side-effect of awaiting a tick before calling emitCreated, which was needed because

We need to delay sending this event until the next tick, since the tab could have been created with a lazy browser but still not have been assigned a SessionStore tab state with the URL and title.

But this shouldn't be necessary after bug 1446426.

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: Bug 1529411 - Fire onCreated before onRemoved when closing last tab with browser.tabs.closeWindowWithLastTab=false. r=mixedpuppy

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5570cf4346a8
Fire onCreated before onRemoved when closing last tab with browser.tabs.closeWindowWithLastTab=false. r=mixedpuppy

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5570cf4346a8

Comment 4

[Oriol Brufau [:Oriol]]

Backed out in bug 1538378.