Closed
Bug 1529420
Opened 5 years ago
Closed 5 years ago
Minor fixes for scroll snap web platform tests
Categories
(Core :: Layout: Scrolling and Overflow, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla67
Tracking | Status | |
---|---|---|
firefox67 | --- | fixed |
People
(Reporter: hiro, Assigned: hiro)
References
Details
Attachments
(2 files)
Though initially I was going to fix all pre-existing issue in the web platform tests in the upstream directly, but I did already send a PR to the upstream, it takes more time than I thought. So I am going to fix rest of the pre-existing issue that I am awake of here.
Assignee | ||
Comment 1•5 years ago
|
||
There is no CSS declaration for #spacer. The element doesn't contribute to the
test at all.
Assignee | ||
Comment 2•5 years ago
|
||
On RTL elements scrollLeft value is negative generally [1].
The original code relies on a Chrome bug [2], it's not yet fixed.
[1] https://github.com/w3c/csswg-drafts/issues/1354
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=721759
Depends on D20588
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e054dd27efa2 Drop a spacer element from overflowing-snap-areas.html. r=botond https://hg.mozilla.org/integration/autoland/rev/e7140d900c30 Fix the expected scrollLeft value in vertical-rl test case. r=botond
Comment 4•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e054dd27efa2
https://hg.mozilla.org/mozilla-central/rev/e7140d900c30
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/15546 for changes under testing/web-platform/tests
Upstream PR merged
You need to log in
before you can comment on or make changes to this bug.
Description
•