Take individual transforms into account for ActiveLayerTracker.

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P3
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: boris, Assigned: boris)

Tracking

(Blocks 1 bug)

Trunk
mozilla67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(4 attachments, 1 obsolete attachment)

Assignee

Description

4 months ago

ActiveLayerTracker checks only eCSSProperty_transform for now. We should update it for other transform-like properties.

Assignee

Updated

4 months ago
Blocks: 1526850
No longer blocks: individual-transform
Assignee

Comment 1

4 months ago

I think it's worth to move the updates related to ActiveLayerTracker into this bug, from Bug 1526850.

Assignee

Updated

4 months ago
Status: NEW → ASSIGNED
Priority: -- → P3
Assignee

Comment 2

4 months ago

So we can let KeyframeEffect::ContainsAnimatedScale check individual
transforms, which is used by ActiveLayerTracker.

Assignee

Comment 3

4 months ago

Sometimes we want to check if there is any transform animations. Here,
we replace the argument of nsCSSPropertyID with nsCSSPropertyIDSet.

Depends on D19630

Assignee

Comment 4

4 months ago

Add comments and property check for the caller of ActivityTracker.

Depends on D19631

Attachment #9045732 - Attachment description: Bug 1529422- Part 4: Check the existence of animations by a property set. → Bug 1529422 - Part 1: Add all transform-like properties into ActiveLayerTracker.
Assignee

Comment 6

4 months ago

HasEffectiveAnimation is used by ActiveLayerTracker, so I go through it
and do some minor refactoring in its similar functions.

Depends on D19631

Attachment #9045733 - Attachment description: Bug 1529422 - Part 5: Make sure the callers of ActivityTracker takes individual transforms into account. → Bug 1529422 - Part 4: Make sure the callers of ActivityTracker takes individual transforms into account.
Attachment #9045734 - Attachment description: Bug 1529422 - Part 8: Add comments in nsDOMCSSDeclaration::SetPropertyValue. → Bug 1529422 - Part 5: Log a warning if webpage is updating individual transforms.
Assignee

Updated

4 months ago
Blocks: individual-transform
No longer blocks: 1526850
Attachment #9045739 - Attachment description: Bug 1529422 - Part 2: A minor refinement in HasEffectiveAnimation. → Bug 1529422 - Part 2: Use property set for IsStyleAnimated.
Attachment #9045731 - Attachment description: Bug 1529422 - Part 3: Let GetScaleValue support individual transforms. → Bug 1529422 - Part 2: Let GetScaleValue support individual transforms.
Attachment #9045733 - Attachment description: Bug 1529422 - Part 4: Make sure the callers of ActivityTracker takes individual transforms into account. → Bug 1529422 - Part 3: Make sure the callers of ActivityTracker takes individual transforms into account.
Attachment #9045734 - Attachment description: Bug 1529422 - Part 5: Log a warning if webpage is updating individual transforms. → Bug 1529422 - Part 4: Log a warning if webpage is updating individual transforms.
Attachment #9045739 - Attachment is obsolete: true

Comment 7

4 months ago
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ee7f3988e84
Part 1: Add all transform-like properties into ActiveLayerTracker. r=hiro,mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/a92c6acc3a94
Part 2: Let GetScaleValue support individual transforms. r=hiro,emilio
https://hg.mozilla.org/integration/autoland/rev/4bbab76b6ec8
Part 3: Make sure the callers of ActivityTracker takes individual transforms into account. r=mstange
https://hg.mozilla.org/integration/autoland/rev/2a82b9a67559
Part 4: Log a warning if webpage is updating individual transforms. r=mstange
You need to log in before you can comment on or make changes to this bug.