Closed Bug 1529422 Opened 1 year ago Closed 1 year ago

Take individual transforms into account for ActiveLayerTracker.

Categories

(Core :: Layout, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: boris, Assigned: boris)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

ActiveLayerTracker checks only eCSSProperty_transform for now. We should update it for other transform-like properties.

Blocks: 1526850
No longer blocks: individual-transform

I think it's worth to move the updates related to ActiveLayerTracker into this bug, from Bug 1526850.

Status: NEW → ASSIGNED
Priority: -- → P3

So we can let KeyframeEffect::ContainsAnimatedScale check individual
transforms, which is used by ActiveLayerTracker.

Sometimes we want to check if there is any transform animations. Here,
we replace the argument of nsCSSPropertyID with nsCSSPropertyIDSet.

Depends on D19630

Add comments and property check for the caller of ActivityTracker.

Depends on D19631

Attachment #9045732 - Attachment description: Bug 1529422- Part 4: Check the existence of animations by a property set. → Bug 1529422 - Part 1: Add all transform-like properties into ActiveLayerTracker.

HasEffectiveAnimation is used by ActiveLayerTracker, so I go through it
and do some minor refactoring in its similar functions.

Depends on D19631

Attachment #9045733 - Attachment description: Bug 1529422 - Part 5: Make sure the callers of ActivityTracker takes individual transforms into account. → Bug 1529422 - Part 4: Make sure the callers of ActivityTracker takes individual transforms into account.
Attachment #9045734 - Attachment description: Bug 1529422 - Part 8: Add comments in nsDOMCSSDeclaration::SetPropertyValue. → Bug 1529422 - Part 5: Log a warning if webpage is updating individual transforms.
Blocks: individual-transform
No longer blocks: 1526850
Attachment #9045739 - Attachment description: Bug 1529422 - Part 2: A minor refinement in HasEffectiveAnimation. → Bug 1529422 - Part 2: Use property set for IsStyleAnimated.
Attachment #9045731 - Attachment description: Bug 1529422 - Part 3: Let GetScaleValue support individual transforms. → Bug 1529422 - Part 2: Let GetScaleValue support individual transforms.
Attachment #9045733 - Attachment description: Bug 1529422 - Part 4: Make sure the callers of ActivityTracker takes individual transforms into account. → Bug 1529422 - Part 3: Make sure the callers of ActivityTracker takes individual transforms into account.
Attachment #9045734 - Attachment description: Bug 1529422 - Part 5: Log a warning if webpage is updating individual transforms. → Bug 1529422 - Part 4: Log a warning if webpage is updating individual transforms.
Attachment #9045739 - Attachment is obsolete: true
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ee7f3988e84
Part 1: Add all transform-like properties into ActiveLayerTracker. r=hiro,mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/a92c6acc3a94
Part 2: Let GetScaleValue support individual transforms. r=hiro,emilio
https://hg.mozilla.org/integration/autoland/rev/4bbab76b6ec8
Part 3: Make sure the callers of ActivityTracker takes individual transforms into account. r=mstange
https://hg.mozilla.org/integration/autoland/rev/2a82b9a67559
Part 4: Log a warning if webpage is updating individual transforms. r=mstange
You need to log in before you can comment on or make changes to this bug.