1529422 - Take individual transforms into account for ActiveLayerTracker.

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Boris Chiou [:boris]]

ActiveLayerTracker checks only eCSSProperty_transform for now. We should update it for other transform-like properties.

Comment 1

[Boris Chiou [:boris]]

I think it's worth to move the updates related to ActiveLayerTracker into this bug, from Bug 1526850.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1529422 - Part 2: Let GetScaleValue support individual transforms.

So we can let KeyframeEffect::ContainsAnimatedScale check individual
transforms, which is used by ActiveLayerTracker.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1529422 - Part 1: Add all transform-like properties into ActiveLayerTracker.

Sometimes we want to check if there is any transform animations. Here,
we replace the argument of nsCSSPropertyID with nsCSSPropertyIDSet.

Depends on D19630

Comment 4

[Boris Chiou [:boris]]

Attachment: Bug 1529422 - Part 3: Make sure the callers of ActivityTracker takes individual transforms into account.

Add comments and property check for the caller of ActivityTracker.

Depends on D19631

Comment 5

[Boris Chiou [:boris]]

Attachment: Bug 1529422 - Part 4: Log a warning if webpage is updating individual transforms.

Depends on D19634

Comment 6

[Boris Chiou [:boris]]

Attachment: Bug 1529422 - Part 2: Use property set for IsStyleAnimated.

HasEffectiveAnimation is used by ActiveLayerTracker, so I go through it
and do some minor refactoring in its similar functions.

Depends on D19631

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ee7f3988e84
Part 1: Add all transform-like properties into ActiveLayerTracker. r=hiro,mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/a92c6acc3a94
Part 2: Let GetScaleValue support individual transforms. r=hiro,emilio
https://hg.mozilla.org/integration/autoland/rev/4bbab76b6ec8
Part 3: Make sure the callers of ActivityTracker takes individual transforms into account. r=mstange
https://hg.mozilla.org/integration/autoland/rev/2a82b9a67559
Part 4: Log a warning if webpage is updating individual transforms. r=mstange

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6ee7f3988e84
https://hg.mozilla.org/mozilla-central/rev/a92c6acc3a94
https://hg.mozilla.org/mozilla-central/rev/4bbab76b6ec8
https://hg.mozilla.org/mozilla-central/rev/2a82b9a67559