1529427 - Refactor sources reducer so that all source actors are included

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Jason Laster [:jlast]]

We filtered the sources in newSources in release 126 to prevent source fields from being clobbered. We should remove that filter and refactor the sources reducer so it is readable and can safely update actors without clobbering fields.

Comment 1

[Jason Laster [:jlast]]

Attachment: Bug 1529427 - Refactor sources reducer so that all source actors are included. r=bhackett

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bf221eea049
Refactor sources reducer so that all source actors are included.

Comment 3

[Andrei Ciure[:aciure]]

Backed out changeset 0bf221eea049 (bug 1529427) for perma failing browser_dbg-windowless-workers.js

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=229944309&revision=0bf221eea0496d0619684e073605032e30c76191

failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=67b131d1aac58cabaea7ce66abebb8bfee142bc9&selectedJob=229949084&searchStr=linux%2Cx64%2Casan%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux64-asan%2Fopt-mochitest-devtools-chrome-e10s-3%2Cm-e10s%28dt3%29

backout: https://hg.mozilla.org/integration/autoland/rev/74006e58ea467b3fd78d405ceb30df68a02acea8

Comment 4

[Jason Laster [:jlast]]

looks like there was a merge conflict. I'll fix it up

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/901be6adcc2d
Refactor sources reducer so that all source actors are included.

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/901be6adcc2d

Comment 7

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/901be6adcc2d