1529495 - Clean up various issues with the OSCrypto_win.js code

Status: RESOLVED FIXED

(Toolkit :: Password Manager, enhancement, P2)

Comment 1

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1529495 - Output the result of ::GetLastError when CryptProtectData\CryptUnprotectData fails. r?ted

Comment 2

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1529495 - Remove unused third argument to OSCrypto.decryptData and OSCrypto.encryptData. r?MattN

Comment 3

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1529495 - Factor out functions for getting the entropy parameter and converting from ctype arrays to JS arrays. r?MattN

Comment 4

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1529495 - Move the call to LocalFree to a try-finally to guarantee we will free the memory even if an exception is thrown. r?MattN

Comment 5

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1529495 - Remove duplication in test_OSCrypto_win.js and add messages for each assertion. r?MattN

Comment 6

[(Away until May 24) Jared Wein [:jaws] (please needinfo? me)]

Try push, https://treeherder.mozilla.org/#/jobs?repo=try&revision=943fb5b7a549b6de08e864fadf4033c11f90a3b5

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b6eccb81c2d
Output the result of ::GetLastError when CryptProtectData\CryptUnprotectData fails. r=MattN
https://hg.mozilla.org/integration/autoland/rev/e39868481a35
Remove unused third argument to OSCrypto.decryptData and OSCrypto.encryptData. r=MattN
https://hg.mozilla.org/integration/autoland/rev/bb8bd993d8db
Factor out functions for getting the entropy parameter and converting from ctype arrays to JS arrays. r=MattN
https://hg.mozilla.org/integration/autoland/rev/829a5803527f
Move the call to LocalFree to a try-finally to guarantee we will free the memory even if an exception is thrown. r=MattN
https://hg.mozilla.org/integration/autoland/rev/b500dd719adb
Remove duplication in test_OSCrypto_win.js and add messages for each assertion. r=MattN

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9b6eccb81c2d
https://hg.mozilla.org/mozilla-central/rev/e39868481a35
https://hg.mozilla.org/mozilla-central/rev/bb8bd993d8db
https://hg.mozilla.org/mozilla-central/rev/829a5803527f
https://hg.mozilla.org/mozilla-central/rev/b500dd719adb