1529505 - Port Bug 1528971 Move newChannel2 being the only implementation within nsIProtocolHandler.idl

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Jorg K (CEST = GMT+2)]

This was fixed as a bustage fix here:
https://hg.mozilla.org/comm-central/rev/d8c70b022d838eb550dcea5c82708946f12e9d4b

r+ for that.

We need a bit of follow-up here. Firstly we have a test failure:
TEST-UNEXPECTED-FAIL | comm/mailnews/compose/test/unit/test_smtpProtocols.js

That's due to this code:

    try {
      // This call should throw NS_ERROR_NOT_IMPLEMENTED. If it doesn't,
      // then we should implement a new test for it.
      pH.newChannel(uri);
      // If it didn't throw, then shout about it.
      do_throw("newChannel not throwing NS_ERROR_NOT_IMPLEMENTED.");
    }
    catch (ex) {
      Assert.equal(ex.result, Cr.NS_ERROR_NOT_IMPLEMENTED);
    }

Also, we should finally follow bug 1452600 comment #16.

Comment 1

[Jorg K (CEST = GMT+2)]

Well, after looking at it again, I've moved "Also, we should finally follow bug 1452600 comment #16." to bug 1529509.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/430756146f2c
Fix test test_smtpProtocols.js: NewChannel() takes two arguments now. r=me DONTBUILD