Open Bug 1529516 Opened 7 months ago Updated 7 months ago

Error stack for logging in TimedPromise only contains it's own frame

Categories

(Testing :: Marionette, enhancement, P1)

enhancement

Tracking

(Not tracked)

REOPENED

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(2 files)

Given that we raise/log the error of a TimedPromise in a callback using errors.stack() the resulted trace only contains the TimedPromise frame but nothing from above. As such it is pretty useless for debugging purposes.

With the above fixed we would clutter the log a lot for calls to Sleep(). As such I would suggest to add some kind of option to fully prevent logging.

Summary: Error stack in TimedPromise is empty and not shown for `throws=null` → Error stack for logging in TimedPromise only contains it's own frame

This is especially needed for "Sleep()", which by default runs
into a timeout condition, but logging it as warning would massively
clutter the log files.

Depends on D20637

Attachment #9045580 - Attachment description: Bug 1529516 - [marionette] Allow callers of TimedPromise to opt-out from logging a warning message. r?ato → Bug 1529516 - [marionette] Use Promise instead of TimedPromise for Sleep(). r?ato
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4e00119c579c
[marionette] Make stacktrace of logged TimedPromise contain the upper stack. r=ato
https://hg.mozilla.org/integration/autoland/rev/0c48c658c7cf
[marionette] Use Promise instead of TimedPromise for Sleep(). r=ato
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Backed out 2 changesets (Bug 1529516) per dev's request for causing issues with wdspec a=backout

Status: RESOLVED → REOPENED
Flags: needinfo?(hskupin)
Resolution: FIXED → ---
Target Milestone: mozilla67 → ---
Backout by nerli@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/9f20371d98ec
Backed out 2 changesets per dev's request for causing issues with wdspec a=backout

Somehow the Sleep() command as heavily used in Action tests is causing a hang. Not sure how this can happen, beside that calling timer.initWithCallback() would raise an error which we don't handle. I will have to investigate it.

Flags: needinfo?(hskupin)
You need to log in before you can comment on or make changes to this bug.