Tweak the available memory tracker thresholds to minimize OOMs

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: gsvelto, Assigned: gsvelto)

Tracking

(Blocks 1 bug)

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Fission Milestone:M2, firefox67 fixed, firefox68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 months ago

Currently the available memory tracker will start sending memory-pressure/low-memory events once we hit 256MiB free commit space (on all Windows systems) or 256MiB free virtual memory (only on 32-bit Windows systems).

Crash ping data shows that ~1/3 of our OOM crashes happen before hitting these thresholds. After bug 675539 lands we should re-evalute the thresholds and tweak them to maximize its impact. There's no point in doing it before as unloading tabs might change fairly dramatically the profile of our OOM crashes.

Updated

3 months ago
Assignee

Updated

2 months ago
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Assignee

Comment 1

2 months ago

After analyzing crash ping data we've established that the current low-memory
detection threshold is too low, there are still a fair number of crashes
happening above it. A 50% increase to 384 MiB should be just about right in
the light of recent telemetry data.

Comment 2

2 months ago
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09479d92114b
Increase the low-memory detection thresholds by 50% r=njn

Comment 3

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Updated

2 months ago
Fission Milestone: --- → M2
Assignee

Comment 4

2 months ago

Comment on attachment 9051622 [details]
Bug 1529556 - Increase the low-memory detection thresholds by 50%

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 675539
  • User impact if declined: Tab unloading is not as effective as it could be in avoiding an OOM crash
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This tweaks two parameters used by the available memory tracker on Windows to detect low-memory scenarios. Increasing those threshold values should help us detect low-memory scenarios more effectively: the original thresholds were based on the nightly population but on beta there's many more OOM crashes coming from 32-bit Windows machines running out of virtual space, the tweaked thresholds should cover better the beta population (and hopefully the release population too). This has been in nightly for a while w/o causing regressions.
  • String changes made/needed: None
Attachment #9051622 - Flags: approval-mozilla-beta?

Comment on attachment 9051622 [details]
Bug 1529556 - Increase the low-memory detection thresholds by 50%

Looks low risk and should improve our OOM crash rate, uplift approved for 67 beta 10, thanks.

Attachment #9051622 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.