152959 - line-height ignored on (certain) table cells [INLINE]

Status: NEW

(Core :: Layout: Block and Inline, defect, P3)

Description

[Hixie (not reading bugmail)]

The line-height property is being ignored on table cells.

   http://www.hixie.ch/tests/adhoc/css/box/inline/007.xml

This is a serious bug, and is one of the few remaining issues we have with our
inline box model.

This is a recent regression.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Ian is referring to bug 151620.

Comment 2

[Hixie (not reading bugmail)]

HTML testcase: http://www.hixie.ch/tests/adhoc/css/box/inline/007.html

Comment 3

[Aaron Kaluszka]

I was afraid of that after looking at how the patch actually operated.  See bug
152959 comment 52 and bug 152959 comment 53 for an alternate (but not as simple)
proposal on how to fix the issue at hand while avoiding bugs like this.

Comment 4

[Hixie (not reading bugmail)]

Some more testcases:
   http://www.hixie.ch/tests/adhoc/css/box/inline/008.xml
   http://www.hixie.ch/tests/adhoc/css/box/inline/008.html

Comment 5

[Hixie (not reading bugmail)]

Even more testcases:
   http://www.hixie.ch/tests/adhoc/css/box/inline/009.xml
   http://www.hixie.ch/tests/adhoc/css/box/inline/009.html

All six testcases work fine on 1.0 branch builds and on trunk builds from before
the bug 151620 checkin.

Comment 6

[Jonas Jørgensen]

If the fix for bug 151620 was backed out with the landing of bug 153032, isn't
this bug fixed now?

Comment 7

[Hixie (not reading bugmail)]

Strangely, no. the following test case (XML and HTML versions) are still broken:
   http://www.hixie.ch/tests/adhoc/css/box/inline/008.xml
   http://www.hixie.ch/tests/adhoc/css/box/inline/008.html

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yeah, I did mention at one point in another bug that I thought our behavior
wasn't quite right.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

In any case, not a regression, and no longer critical for 1.1 (I think).

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information