1529698 - Split nsDisplayWrapList for different use cases

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement, P2)

Description

[Miko Mynttinen]

Currently nsDisplayWrapList is used

1. as a baseclass for container items
2. as a baseclass for items that can be merged during painting
3. for sorting display item groups during display list building

This makes it big and unnecessarily slow, especially for sorting, where we only use it as a thin grouping wrapper.

Comment 1

[Matt Woodrow (:mattwoodrow)]

The 3rd use case doesn't need most of the members in nsDisplayItem, so it might be worth making the sorting wrapper not inherit from that.

Comment 2

[Miko Mynttinen]

Attachment: Bug 1529698 - Part 1: Make LayerState enum class r=mattwoodrow

Comment 3

[Miko Mynttinen]

Attachment: Bug 1529698 - Part 2: Move BuildLayer() to nsPaintedDisplayItem r=mattwoodrow

Depends on D30837

Comment 4

[Miko Mynttinen]

Attachment: Bug 1529698 - Part 3: Move DisplayItemData to nsPaintedDisplayItem r=mattwoodrow

Depends on D30838

Comment 5

[Miko Mynttinen]

Attachment: Bug 1529698 - Part 4: Add nsDisplayContainer r=mattwoodrow

Depends on D30839

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7db30b209d7e
Part 1: Make LayerState enum class r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/5d245d6070e0
Part 2: Move BuildLayer() to nsPaintedDisplayItem r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/40280b1c2aff
Part 3: Move DisplayItemData to nsPaintedDisplayItem r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/e37407909f92
Part 4: Add nsDisplayContainer r=mattwoodrow

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7db30b209d7e
https://hg.mozilla.org/mozilla-central/rev/5d245d6070e0
https://hg.mozilla.org/mozilla-central/rev/40280b1c2aff
https://hg.mozilla.org/mozilla-central/rev/e37407909f92