1529911 - Add more tests for cancelling HTTP channels

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P3)

Description

[Valentin Gosu [:valentin] (he/him)]

Try to land these patches:

https://phabricator.services.mozilla.com/D20501
https://phabricator.services.mozilla.com/D20500
https://phabricator.services.mozilla.com/D20499

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1529911 - Make the httpcancel unit test run in e10s r=mayhemer

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1529911 - Add more tests for cancelling the channel r=mayhemer

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1529911 - Ensure that mOnStartRequestCalled/mOnStopRequestCalled is set just before calling the listener to avoid reentrancy issues r=mayhemer

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1529911 - Fix web-platform-test expectations r=mayhemer

Because the IPDL channel between HttpChannelChild/Parent is sensitive to chaos
mode delays, sometimes the channel will be cancelled before completing, other
times after.
Because of this, the test will sometimes fail in verify mode.

Depends on D20499

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80a8e4e5d1f4
Make the httpcancel unit test run in e10s r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/5505832bc5ed
Add more tests for cancelling the channel r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/671660d801fe
Ensure that mOnStartRequestCalled/mOnStopRequestCalled is set just before calling the listener to avoid reentrancy issues r=mayhemer
https://hg.mozilla.org/integration/autoland/rev/52f7de8a8df0
Fix web-platform-test expectations r=mayhemer

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/80a8e4e5d1f4
https://hg.mozilla.org/mozilla-central/rev/5505832bc5ed
https://hg.mozilla.org/mozilla-central/rev/671660d801fe
https://hg.mozilla.org/mozilla-central/rev/52f7de8a8df0

Comment 8

[Honza Bambas (:mayhemer)]

Comment on attachment 9066169 [details]
Bug 1529911 - Ensure that mOnStartRequestCalled/mOnStopRequestCalled is set just before calling the listener to avoid reentrancy issues r=mayhemer

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Fix a medium-rate null-deref crash on Fennec, bug 1546191. (Regarding test uplift, this needs to be tested if the patch on its own breaks existing, unpatched tests or not)
• User impact if declined: Occasional crash during normal browsing when using addons like uBlock or AdBlock
• Fix Landed on Version: 69
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch is silently preventing break of nsIStreamListener contract (duplicate calls) only. There is no risk of hanging, indefinite loading or crashes.
• String or UUID changes made by this patch:

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9066169 [details]
Bug 1529911 - Ensure that mOnStartRequestCalled/mOnStopRequestCalled is set just before calling the listener to avoid reentrancy issues r=mayhemer

May help with a Fennec topcrash. Approved for Fennec 68.2b3.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/1b02e9751095
https://hg.mozilla.org/releases/mozilla-esr68/rev/a253c37850f7
https://hg.mozilla.org/releases/mozilla-esr68/rev/c47da102007d
https://hg.mozilla.org/releases/mozilla-esr68/rev/8f6f609ba95d