1529938 - Tests in test_screen_orientation.py have to wait for orientationchange after setting new orientation

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P1)

Description

[Jan Henning [:JanH]]

See bug 1527959 comment 14

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=633e33ea2f7ca993fa72f8a52dd3b5fa4887a6df

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1529938 - [marionette] Wait for "orientationchange" event when changing screen orientation. r?ato

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Tests are causing infinite hangs now because in some situations the event is not getting emitted. I'm not sure what's wrong here.

Given that I'm away the next days maybe Geoff or Jan could have a look at it?

Comment 4

[Geoff Brown [:gbrown]]

Thanks :whimboo. I've gotten as far as confirming your observations, but don't have further insight.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Oh, I just read bug 1527959 comment 17 again, and it's clear now why that cannot work. Before we can make any changes to Marionette server itself, only the test needs the update. The server change has to follow when bug 1527959 has been fixed.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Here a new try build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fc495658a423b94f7c116008eab97a0c805ad10

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1529938 - [marionette] Tests for screen orientation change have to wait for the change happened. r?gbrown

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Also restoring the the summary to reflect the reality of this bug.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0f848b99ad57
[marionette] Tests for screen orientation change have to wait for the change happened. r=gbrown

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/0f848b99ad57