Tests in test_screen_orientation.py have to wait for orientationchange after setting new orientation

RESOLVED FIXED in Firefox 67

Status

defect
P1
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: JanH, Assigned: whimboo)

Tracking

(Blocks 1 bug)

Trunk
mozilla67
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Status: NEW → ASSIGNED
Priority: -- → P1
Summary: test_screen_orientation.py should wait for orientationchange event before querying new orientation → "Marionette:SetScreenOrientation" has to wait for "orientationchange" event

Tests are causing infinite hangs now because in some situations the event is not getting emitted. I'm not sure what's wrong here.

Given that I'm away the next days maybe Geoff or Jan could have a look at it?

Flags: needinfo?(jh+bugzilla)
Flags: needinfo?(gbrown)

Thanks :whimboo. I've gotten as far as confirming your observations, but don't have further insight.

Flags: needinfo?(gbrown)

Oh, I just read bug 1527959 comment 17 again, and it's clear now why that cannot work. Before we can make any changes to Marionette server itself, only the test needs the update. The server change has to follow when bug 1527959 has been fixed.

Flags: needinfo?(jh+bugzilla)
Attachment #9047039 - Attachment is obsolete: true

Also restoring the the summary to reflect the reality of this bug.

Summary: "Marionette:SetScreenOrientation" has to wait for "orientationchange" event → Tests in test_screen_orientation.py have to wait for orientationchange after setting new orientation
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f848b99ad57
[marionette] Tests for screen orientation change have to wait for the change happened. r=gbrown
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.