Closed Bug 1529955 Opened 6 years ago Closed 6 years ago

remove corruption canary from LogModule

Categories

(Core :: XPCOM, enhancement)

Product:
Core
Component:
XPCOM
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file, 1 obsolete file)

remove corruption canary from LogModule
1.50 KB, patch
erahm
: review+
Details | Diff | Splinter Review

This canary isn't catching anything interesting, so we might as well
save a little bit of overhead by removing it.

Attachment #9045983 - Flags: review?(erahm)
Comment on attachment 9045983 [details] [diff] [review] remove corruption canary from LogModule Review of attachment 9045983 [details] [diff] [review]: ----------------------------------------------------------------- I think this is sitting on top of some local changes, can you re-request w/o them. Also you can you use phab for the next request?
Attachment #9045983 - Flags: review?(erahm)
You're right, I had some bug 1525953 patches in my queue. Fixed.
Attachment #9046319 - Flags: review?(erahm)
Attachment #9045983 - Attachment is obsolete: true
Comment on attachment 9046319 [details] [diff] [review] remove corruption canary from LogModule Review of attachment 9046319 [details] [diff] [review]: ----------------------------------------------------------------- Can you remove the Poison.h include as well?
Attachment #9046319 - Flags: review?(erahm) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/739c3b30b230 remove corruption canary from LogModule; r=erahm

https://hg.mozilla.org/mozilla-central/rev/739c3b30b230

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox67: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: