remove corruption canary from LogModule

RESOLVED FIXED in Firefox 67

Status

()

enhancement
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

3 months ago

This canary isn't catching anything interesting, so we might as well
save a little bit of overhead by removing it.

Assignee

Comment 1

3 months ago
Attachment #9045983 - Flags: review?(erahm)
Comment on attachment 9045983 [details] [diff] [review]
remove corruption canary from LogModule

Review of attachment 9045983 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is sitting on top of some local changes, can you re-request w/o them. Also you can you use phab for the next request?
Attachment #9045983 - Flags: review?(erahm)
Assignee

Comment 3

3 months ago
You're right, I had some bug 1525953 patches in my queue.  Fixed.
Attachment #9046319 - Flags: review?(erahm)
Assignee

Updated

3 months ago
Attachment #9045983 - Attachment is obsolete: true
Comment on attachment 9046319 [details] [diff] [review]
remove corruption canary from LogModule

Review of attachment 9046319 [details] [diff] [review]:
-----------------------------------------------------------------

Can you remove the Poison.h include as well?
Attachment #9046319 - Flags: review?(erahm) → review+

Comment 5

3 months ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/739c3b30b230
remove corruption canary from LogModule; r=erahm

Comment 6

3 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.