Closed Bug 1530134 Opened 4 years ago Closed 4 years ago

mach clang-format doesn't work without docker

Categories

(NSS :: Build, enhancement)

Product:
NSS
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mt, Assigned: mt)

Details

Attachments

(1 file)

Bug 1530134 - Don't not run clang-format unless it cannot fail to execute without non-docker, r?jcj
47 bytes, text/x-phabricator-request
Details | Review

Yes, having docker is probably ideal, because it means we get a consistent version, but most of the time it doesn't matter which version of clang-format we run. There are only a few files that get badly formatted in recent versions.

This runs the script directly if docker doesn't run (WSL being my case).

Attachment #9046181 - Attachment description: Bug 1530134 - Run clang-format without non-docker, r?jcj → Bug 1530134 - Don't not run clang-format unless it cannot fail to execute without non-docker, r?jcj

slowest. push. e. v. e. r. https://hg.mozilla.org/projects/nss/rev/ee8e4996a6b364a2d7c65fd734afcb63c865ac7b

Status: NEW → RESOLVED
Closed: 4 years ago
OS: Unspecified → All
Hardware: Unspecified → All
Resolution: --- → FIXED
Target Milestone: --- → 3.43
Summary: mach clang-format doesn't with without docker → mach clang-format doesn't work without docker
You need to log in before you can comment on or make changes to this bug.