1530182 - Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_minimize.js

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

This is a good first bug for newcomers to Firefox development.

All promiseWaitForCondition usage in the browser_minimize.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/browser_minimize.js#10,13,16

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_minimize.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

Comment 1

[Neha]

I would like to work on this.
Can this issue be assigned to me?
Thanks!

Comment 2

[Johann Hofmann [:johannh]]

Of course, let me know if you need help!

Comment 3

[Neha]

Attachment: Bug 1530182 - Replaced promiseWaitForCondition with TestUtils.waitForCondition in browser_minimize.js. r=reviewers

Replaced promiseWaitForCondition with TestUtils.waitForCondition. Replaced all occurences of promiseWaitForCondition with TstUtils.waitForCondition, in mozilla-central/browser/base/content/test/general/browser_minimize.js

Comment 4

[Johann Hofmann [:johannh]]

Thank you for your contribution! To get your patch checked in I've set the checkin-needed keyword.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/69598c5631ce
Replaced promiseWaitForCondition with TestUtils.waitForCondition in browser_minimize.js. r=johannh

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/69598c5631ce

Comment 7

[Johann Hofmann [:johannh]]

Thank you Neha, well done! If you are looking for another, more challenging, bug, may I suggest bug 1511834? I have added a comment on how to approach the problem and as always, let me know if you need any help.

Thanks!

Comment 8

[Neha]

Thanks!
I will take look at that bug and try to solve it as soon as possible.

Comment 9

[Neha]

Attachment: Bug 1530182 - Replaced promiseWaitForCondition with TestUtils.waitForCondition in browser_minimize.js. r=reviewers

Replaced promiseWaitForCondition with TestUtils.waitForCondition. Replaced all occurences of promiseWaitForCondition with TstUtils.waitForCondition, in mozilla-central/browser/base/content/test/general/browser_minimize.js

Bug 1523290 - Test for JSTerm menu in Browser Console

Comment 10

[Phabricator Automation]

Comment on attachment 9047446 [details]
Bug 1530182 - Replaced promiseWaitForCondition with TestUtils.waitForCondition in browser_minimize.js. r=reviewers

Revision D21564 was moved to bug 1523290. Setting attachment 9047446 [details] to obsolete.