Replace promiseWaitForCondition with TestUtils.waitForCondition in browser_minimize.js

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P5
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: johannh, Assigned: ns19041997, Mentored)

Tracking

({good-first-bug})

unspecified
Firefox 67
Points:
---

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

This is a good first bug for newcomers to Firefox development.

All promiseWaitForCondition usage in the browser_minimize.js test file can be replaced by the TestUtils.waitForCondition utility function.

The code in question is here: https://searchfox.org/mozilla-central/rev/dc0adc07db3df9431a0876156f50c65d580010cb/browser/base/content/test/general/browser_minimize.js#10,13,16

For instructions on how to get your local build of Firefox up and running and submit your patch, see https://developer.mozilla.org/en-US/docs/Introduction.

You can run this test with the ./mach mochitest command:

./mach mochitest browser/base/content/test/general/browser_minimize.js

Please leave a comment if you would like to be assigned to this bug and feel free to ask questions here or via IRC if you're stuck.

I would like to work on this.
Can this issue be assigned to me?
Thanks!

Of course, let me know if you need help!

Assignee: nobody → ns19041997
Status: NEW → ASSIGNED

Replaced promiseWaitForCondition with TestUtils.waitForCondition. Replaced all occurences of promiseWaitForCondition with TstUtils.waitForCondition, in mozilla-central/browser/base/content/test/general/browser_minimize.js

Thank you for your contribution! To get your patch checked in I've set the checkin-needed keyword.

Keywords: checkin-needed

Pushed by csabou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/69598c5631ce
Replaced promiseWaitForCondition with TestUtils.waitForCondition in browser_minimize.js. r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67

Thank you Neha, well done! If you are looking for another, more challenging, bug, may I suggest bug 1511834? I have added a comment on how to approach the problem and as always, let me know if you need any help.

Thanks!

Thanks!
I will take look at that bug and try to solve it as soon as possible.

Replaced promiseWaitForCondition with TestUtils.waitForCondition. Replaced all occurences of promiseWaitForCondition with TstUtils.waitForCondition, in mozilla-central/browser/base/content/test/general/browser_minimize.js

Bug 1523290 - Test for JSTerm menu in Browser Console

Comment on attachment 9047446 [details]
Bug 1530182 - Replaced promiseWaitForCondition with TestUtils.waitForCondition in browser_minimize.js. r=reviewers

Revision D21564 was moved to bug 1523290. Setting attachment 9047446 [details] to obsolete.

Attachment #9047446 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.