CanRecordInProcess returns wrong result due to wrong usage of bitflag comparison

RESOLVED FIXED in Firefox 67

Status

()

enhancement
P1
normal
RESOLVED FIXED
4 months ago
2 months ago

People

(Reporter: janerik, Assigned: janerik)

Tracking

unspecified
mozilla67
Points:
1

Firefox Tracking Flags

(firefox67 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

4 months ago

The CanRecordInProcess function should determine if some probe can be recorded for the given process.
It should only return true, when:

  • "All processes" are allowed
  • The given process is in the list of allowed processes
  • The given process is not the main process and "all children" are allowed

However, it currently fails to do so correctly and allows a lot of probes on processes that it shouldn't (e.g. probes that are [main, content] are allowed on other child processes such as "gpu" and "socket").

This is due to the way the bitflags are checked.

Attachment #9046368 - Attachment description: Bug 1530361 - Properly check if process is allowed → Bug 1530361 - Properly check if child process is allowed

Comment 2

4 months ago
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3fd93ab694f
Properly check if child process is allowed r=chutten

Comment 3

4 months ago
bugherder
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in before you can comment on or make changes to this bug.