Closed
Bug 1530361
Opened 5 years ago
Closed 5 years ago
CanRecordInProcess returns wrong result due to wrong usage of bitflag comparison
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: janerik, Assigned: janerik)
References
Details
Attachments
(1 file)
The CanRecordInProcess function should determine if some probe can be recorded for the given process.
It should only return true, when:
- "All processes" are allowed
- The given process is in the list of allowed processes
- The given process is not the main process and "all children" are allowed
However, it currently fails to do so correctly and allows a lot of probes on processes that it shouldn't (e.g. probes that are [main, content] are allowed on other child processes such as "gpu" and "socket").
This is due to the way the bitflags are checked.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Updated•5 years ago
|
Attachment #9046368 -
Attachment description: Bug 1530361 - Properly check if process is allowed → Bug 1530361 - Properly check if child process is allowed
Pushed by jrediger@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c3fd93ab694f Properly check if child process is allowed r=chutten
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
You need to log in
before you can comment on or make changes to this bug.
Description
•