Play Tab indicator for pinned tabs isn't working
Categories
(Firefox :: Tabbed Browser, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox65 | --- | unaffected |
| firefox66 | --- | verified |
| firefox67 | --- | verified |
People
(Reporter: hyacoub, Assigned: jaws)
References
Details
(Keywords: regression)
Attachments
(1 external file)
[Affected versions]:
Nightly 67.0a1, Firefox 66.0b11
[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.14, and Ubuntu 16.04 x64.
[Steps to reproduce]:
- Open Firefox and go to youtube.com
- Open several videos in background tabs without focusing them
- Pin any of the unfocused tabs by:
-right click on each tab -> select Pin Tab
-right click on each tab -> hit P key - On any of the pinned tabs click on the Play Tab indicator
[Expected result]:
Media is unblocked and the sound indicator replaces the Play tab one.
[Actual result]:
Play Tab indicator for pinned tabs isn't working.
| Reporter | ||
Updated•7 years ago
|
Updated•7 years ago
|
Comment 1•7 years ago
|
||
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=507fae6b3eb45429cbd3ea034d1d0477b63b39ca&tochange=e1faf5fa77a67493a392649b3e4158570331f652
Regressed by:e1faf5fa77a6 Jared Wein — Bug 1514613 - Use originalTarget instead of relying on _overPlayingIcon where possible. r=dao
| Assignee | ||
Updated•7 years ago
|
| Assignee | ||
Comment 3•7 years ago
|
||
This attribute was overlooked previously when moving away from _overPlayingIcon.
Updated•7 years ago
|
Comment 5•7 years ago
|
||
| bugherder | ||
Comment 6•7 years ago
|
||
Is this worth uplifting to beta66?
| Assignee | ||
Comment 7•7 years ago
|
||
Comment on attachment 9047187 [details]
Bug 1530367 - Toggle audio playback when clicking on blocked media in pinned tabs. r?dao
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: Bug 1514613
- User impact if declined: Unblocking media on pinned tabs will fail
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Adds back a case that was missed in the regressing patch. The change is very specific to this case.
- String changes made/needed: none
Comment 8•7 years ago
|
||
Comment on attachment 9047187 [details]
Bug 1530367 - Toggle audio playback when clicking on blocked media in pinned tabs. r?dao
Low risk, has test coverage, OK for uplift for beta 14.
Comment 9•7 years ago
|
||
| bugherder uplift | ||
Updated•7 years ago
|
Updated•7 years ago
|
Comment 10•7 years ago
•
|
||
I reproduced this issue using Fx 66.0b11, build ID: 20190225143245, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx Nightly 67.0a1 Build ID: 20190308093915 and Fx 66.0b14, build ID: 20190307095232, on Windows 10 x64, macOS X 10.13 and Ubuntu 18.04 LTS.
Updated•7 years ago
|
Description
•