1530391 - Intermittent: less: not found

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Andreea Pavel [:apavel]]

Treeherder link: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&selectedJob=230260759

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=230260759&repo=mozilla-central&lineNumber=1486

comparing with https://hg.mozilla.org/mozilla-central
searching for changes
/bin/sh: 1: less: not found
[taskcluster 2019-02-25 10:07:57.980Z] === Task Finished ===
[taskcluster 2019-02-25 10:07:58.740Z] Unsuccessful task run with exit code: 255 completed in 228.572 seconds

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

It looks like this is a crontask to update the funsize pipfile. It seems the pipfile diff is getting large enough that the diff implementation is trying to use a pager -- and no pager is installed. I see sfraser in REVIEWERs, so I'm figuring you know something about this :)

Comment 2

[Simon Fraser [:sfraser] ⌚️GMT]

This seems to be set in https://hg.mozilla.org/mozilla-central/file/tip/taskcluster/docker/recipes/hgrc#l33

Since none of the places that draw that in are interactive, I'd like to turn it off there rather than special-case this current image. Thoughts?

Comment 3

[Tom Prince [:tomprince]]

I suspect that line is there to support people using interactive tasks.

Comment 4

[Simon Fraser [:sfraser] ⌚️GMT]

(In reply to Tom Prince [:tomprince] from comment #3)

I suspect that line is there to support people using interactive tasks.

Agreed. I don't know if that's a large enough user-base to warrant not changing it, though. Perhaps an hgrc-interactive option to %include?

Comment 5

[Simon Fraser [:sfraser] ⌚️GMT]

Attachment: Bug 1530391 Add a pager for mercurial commands r=dustin

Comment 6

[Simon Fraser [:sfraser] ⌚️GMT]

Ideally, a tool shouldn't try to use a pager if it detects it's not running with a terminal (and this invocation is piped to 'tee'). Option 2 would be to set up non-interactive tasks so they're configured that way, but for now the patch is a workaround.

Comment 7

[Mike Hommey [:glandium]]

The problem is that our docker setup makes processes running under think they are running in a terminal. Thus the tool trying to use a pager. Now, the side effect of installing less might be that now, it will find a pager, the pager will be used, and the pager will stay there forever waiting for user input...

Comment 8

[Mike Hommey [:glandium]]

A better option might be to add:

[ui]
paginate = never

to hgrc. Or to pass --config ui.paginate=never on the mercurial command line (so that the pager still works in interactive tasks)

Comment 9

[Mike Hommey [:glandium]]

(and this invocation is piped to 'tee')

That doesn't seem plausible. The last log lines before the failure say:

comparing with https://hg.mozilla.org/mozilla-central
searching for changes

and that's after the diff.

That looks like this would come from the ${HG} -R "${REPODIR}" out or push_repo command.

Comment 10

[Mike Hommey [:glandium]]

BTW, it would be good to add set -x to the script so that it's clearer what command it is that fails (in the future).

Comment 11

[Simon Fraser [:sfraser] ⌚️GMT]

(In reply to Mike Hommey [:glandium] from comment #9)

That looks like this would come from the ${HG} -R "${REPODIR}" out or push_repo command.

You're right, I misread that.

Comment 12

[Simon Fraser [:sfraser] ⌚️GMT]

(In reply to Mike Hommey [:glandium] from comment #8)

A better option might be to add:

[ui]
paginate = never

to hgrc. Or to pass --config ui.paginate=never on the mercurial command line (so that the pager still works in interactive tasks)

Adding (and remembering to add!) that to every invocation seems like an awkward workaround. I could alias 'hg' at the top, I suppose.

Part of my reluctance is that I do expect interactive tasks based on non-interactive originals to not have all the niceties, so I'm unsure how far we should be bending to make things convenient at the expense of the task's main operating mode.

Comment 13

[Dustin J. Mitchell [:dustin] (he/him)]

Disabling paging for interactive use only means having to run hg diff | less in the cases where the diff is too big -- maybe changing the default is the least-bad option?

Comment 14

[Mike Hommey [:glandium]]

Setting the HGPLAIN environment variable should do it too.

Comment 15

[Simon Fraser [:sfraser] ⌚️GMT]

Attachment: Bug 1530391 Disable hg extensions incompatible automated tasks r=dustin

I've set HGPLAIN in the container entrypoint so that people running
the main script interactively still get the nice features.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45b6b4f345d5
Disable hg extensions incompatible automated tasks r=dustin

Comment 17

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/45b6b4f345d5

Comment 18

[Intermittent Failures Robot]

2 failures in 2981 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2

Platform breakdown:

• linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1530391&startday=2019-02-25&endday=2019-03-03&tree=all