1530412 - Add LazyScriptData type instead of void* field

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Ted Campbell [:tcampbell]]

Currently LazyScript has a |void* table_| field to store optional variable-length data. We should migrate to a better encapsulated structure to simplify initialization/XDR/cloning/GC issues, similar to what was done with PrivateScriptData.

The numClosedOverBindings/numInnerFunctions/fieldInitializers fields should all be moved over to this data structure.

Moving the numClosedOverBindings length to LazyScriptData would be a slight memory regression, but it is also desirable to standardize the flags of LazyScript to match JSScript. Moving the fieldInitializers stuff to LazyScriptData will make it optional and revert some of the memory regression that that change causes.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1530412 - Add js::LazyScriptData type

Comment 2

[Ted Campbell [:tcampbell]]

Attachment: Bug 1530412 - Add toStringEnd argument to LazyScript::CreateForXDR

Simplify placeholders and add toStringEnd argument.

Depends on D23398

Comment 3

[Ted Campbell [:tcampbell]]

Attachment: Bug 1530412 - Move LazyScript::numClosedOverBindings/numInnerFunctions to normal fields

Depends on D23399

Comment 4

[Ted Campbell [:tcampbell]]

Attachment: Bug 1530412 - Use JSScript::ImmutableFlags in LazyScript

Depends on D23400

Comment 5

[Ted Campbell [:tcampbell]]

Attachment: Bug 1530412 - Use mozilla::Span for LazyScript tables

Depends on D23402

Comment 6

[Ted Campbell [:tcampbell]]

Attachment: Bug 1530412 - Use LazyScriptData for LazyScript

Depends on D23403

Comment 7

[Ted Campbell [:tcampbell]]

Attachment: Bug 1530412 - Fix LazyScript constructor argument names

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/896a538f502b
Fix LazyScript constructor argument names r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/0b61c4bdd578
Add toStringEnd argument to LazyScript::CreateForXDR r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/618b7bbaebbe
Move LazyScript::numClosedOverBindings/numInnerFunctions to normal fields r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/539d7eec3444
Use mozilla::Span for LazyScript tables r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/a93ef3e7f2b9
Use JSScript::ImmutableFlags in LazyScript r=jandem
https://hg.mozilla.org/integration/autoland/rev/5bd984729daf
Add js::LazyScriptData type r=jorendorff
https://hg.mozilla.org/integration/autoland/rev/348419a9d041
Use LazyScriptData for LazyScript r=jorendorff

Comment 9

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/896a538f502b
https://hg.mozilla.org/mozilla-central/rev/0b61c4bdd578
https://hg.mozilla.org/mozilla-central/rev/618b7bbaebbe
https://hg.mozilla.org/mozilla-central/rev/539d7eec3444
https://hg.mozilla.org/mozilla-central/rev/a93ef3e7f2b9
https://hg.mozilla.org/mozilla-central/rev/5bd984729daf
https://hg.mozilla.org/mozilla-central/rev/348419a9d041