1530489 - Crash in [@ mozilla::gfx::VRParent::ActorDestroy]

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-e9190007-b07d-45a1-90ee-376080190224.

Seen while looking at nightly crash stats: https://bit.ly/2tzWcL6. 2 Win 7 crashes in nightly so far, starting in Build 20190223041557.

Top 10 frames of crashing thread:

0 xul.dll void mozilla::gfx::VRParent::ActorDestroy gfx/vr/ipc/VRParent.cpp:101
1 xul.dll mozilla::PProfilerParent::OnChannelClose ipc/ipdl/PFunctionBrokerChild.cpp:165
2 xul.dll nsresult mozilla::detail::RunnableMethodImpl<mozilla::dom::ServiceWorkerRegistration*, void  xpcom/threads/nsThreadUtils.h:1171
3 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1162
4 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:474
5 xul.dll void mozilla::ipc::MessagePump::Run ipc/glue/MessagePump.cpp:88
6 xul.dll MessageLoop::RunHandler ipc/chromium/src/base/message_loop.cc:308
7 xul.dll MessageLoop::Run ipc/chromium/src/base/message_loop.cc:290
8 xul.dll nsBaseAppShell::Run widget/nsBaseAppShell.cpp:137
9 xul.dll nsAppShell::Run widget/windows/nsAppShell.cpp:411

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1530489 - Checking VRGPUParent is available before closing it.

Comment 2

[Daosheng Mu[:daoshengmu]]

:kip, IIRC, we don't wanna Win 7 users use WebVR, do you remember if we block them in Win 7? If so, I think VR process also needs to follow the same rule.

Comment 3

[:kip (Kearwood Gilbert)]

(In reply to Daosheng Mu[:daoshengmu] from comment #2)

:kip, IIRC, we don't wanna Win 7 users use WebVR, do you remember if we block them in Win 7? If so, I think VR process also needs to follow the same rule.

Oculus Rift requires Windows 10; however, HTC Vive still supports Windows 7.

We do require 64-bit builds; however.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b84cbe0e2a3
Checking VRGPUParent is available before closing it. r=kip

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9b84cbe0e2a3