Closed Bug 1530588 Opened 6 months ago Closed 6 months ago

Remove duplicate copy of geckoState in VRSystemManagerExternal::PushState

Categories

(Core :: WebVR, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox65 --- unaffected
firefox66 --- fixed
firefox67 --- fixed

People

(Reporter: daoshengmu, Assigned: daoshengmu)

References

Details

Attachments

(2 files)

No description provided.
Assignee: nobody → dmu
Blocks: 1514417

It seems like a mistake when doing merge at Bug 1514417.

It also needs to be uplift to Beta as well.

Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb361d09129f
Remove duplicate copy of geckoState in VRSystemManagerExternal::PushState. r=kip
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Attached patch bug1530588.patchSplinter Review

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1514417
  • User impact if declined: We don't wanna do the same copy twice. If we decline it, it will bring potential performance issue especially for this kind of big chunk, and we do this copy every frame.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It just removes the duplicate wrong copy-paste code.
  • String changes made/needed:
Attachment #9047546 - Flags: approval-mozilla-beta?

We need to do a little adjustment at attachment 9047546 [details] [diff] [review] for helping the difference between central and beta.

Comment on attachment 9047546 [details] [diff] [review]
bug1530588.patch

Regression from 66, may affect performance. 
OK for uplift for beta 13.
Attachment #9047546 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.