1530588 - Remove duplicate copy of geckoState in VRSystemManagerExternal::PushState

Status: RESOLVED FIXED

(Core :: WebVR, enhancement)

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1530588 - Remove duplicate copy of geckoState in VRSystemManagerExternal::PushState.

MozReview-Commit-ID: Emmkw2CazxB

Comment 2

[Daosheng Mu[:daoshengmu]]

It seems like a mistake when doing merge at Bug 1514417.

Comment 3

[Daosheng Mu[:daoshengmu]]

It also needs to be uplift to Beta as well.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb361d09129f
Remove duplicate copy of geckoState in VRSystemManagerExternal::PushState. r=kip

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/bb361d09129f

Comment 6

[Daosheng Mu[:daoshengmu]]

Attachment: bug1530588.patch

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1514417
• User impact if declined: We don't wanna do the same copy twice. If we decline it, it will bring potential performance issue especially for this kind of big chunk, and we do this copy every frame.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It just removes the duplicate wrong copy-paste code.
• String changes made/needed:

Comment 7

[Daosheng Mu[:daoshengmu]]

We need to do a little adjustment at attachment 9047546 [details] [diff] [review] for helping the difference between central and beta.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9047546 [details] [diff] [review]
bug1530588.patch

Regression from 66, may affect performance. 
OK for uplift for beta 13.

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a57747b9852b