1530683 - 2019-02-26 build lost my session

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Andrew Overholt [:overholt]]

I clicked "restart to update", Firefox didn't restart, and when I restarted it manually my session was gone. History appears accurate but my pinned and non-pinned tabs are gone.

Comment 1

[Sean Feng [:sefeng]]

Running Ubuntu 18.10 here. After I clicked "restart to update", my FF restarted and crashed immediately. When I restarted it manually my session was gone too.

Comment 2

[Pascal Chevrel:pascalc]

Just applied the update and had the same bug. Loading about:sessionrestore manually allowed me to restore my previous session.

Comment 3

[Pascal Chevrel:pascalc]

pushlog between the last 2 builds:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=49b2a4c8be01&tochange=110ea2a7c3d4

One session restore bug in that range:
https://bugzilla.mozilla.org/show_bug.cgi?id=1442694

Doug, fyi this patch may have caused this regression.

One oddity on restart is that the session was empty with one pinned blank tab, I believe that Julien also had the same blank pinned tab.

Comment 4

[Andrew Overholt [:overholt]]

(FWIW I don't think I had one blank pinned tab)

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I had the same problem with this morning's build https://hg.mozilla.org/mozilla-central/rev/110ea2a7c3d4f34b5079c195f7ea57966748e6da . This morning I woke up, did the update to last night's build that I hadn't done yet, went away for 25-30 minutes, did this morning's update (like the previous, via the green notification on the hamburger menu), and the second update ended up with a weird partial-restore of the session (there were the right number of windows, not enough tabs in them, and all the tabs were blank). I quit Firefox, restored the sessionstore from the first update I did this morning (to last night's build) (cd <profile-dir>/sessionstore-backups/; cp -p upgrade.jsonlz4-20190225215823 ../sessionstore.jsonlz4) and then it restored correctly.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(I had multiple blank pinned tabs, I think... but not as many pinned tabs as I should have had.)

Comment 7

[Alex Thayer [:alexical] (she/her)]

Uh oh, looking into this.

Comment 8

[Julien Cristau [:jcristau]]

For now nightly updates are pinned to the 20190225215823 build.

Comment 9

[Julien Cristau [:jcristau]]

Backed out from central:
https://hg.mozilla.org/mozilla-central/rev/4a87b6ac14c0

Comment 11

[Marcia Knous [:marcia]]

Is there a way for this to be caught in automated testing?

Comment 12

[Alex Thayer [:alexical] (she/her)]

I am adding tests which recreate this and similar failures before implementing the fix. More generally, it seems that there just wasn't as much breadth in pinned tabs testing as would have been necessary to catch this.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

(In reply to Julien Cristau [:jcristau] from comment #8)

For now nightly updates are pinned to the 20190225215823 build.

Respins with the backout are available. I've removed the pinning rule.

Comment 14

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.