1530712 - Make sure extensions installed via policy are enabled

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, enhancement, P1)

Description

[Mike Kaply [:mkaply]]

Customer is reporting that extensions installed via policy are disabled.

While I can't recreate except in one case, we don't have code that does this explicitly and we should.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1530712 - Enable addon after installation via policy.

Comment 2

[Mike Kaply [:mkaply]]

1. The customer problem was unrelated. They were installing as a third party.

2. This did expose an ESR only bug - if a user disabled an addon then after install, it stays disabled. This isn't happening on nightly.

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 9046835 [details]
Bug 1530712 - Enable addon after installation via policy.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is an ESR only patch to solve a case where if a policy installed an extension, and that extension had already been installed and disabled by the user, it wouldn't get reinstalled.

This is not an issue on current builds because of https://bugzilla.mozilla.org/show_bug.cgi?id=1313298.

Testing this is pretty straightforward. Install an addon via policy, disable it. Then clear the runOnce preference in about:config. Restart the browser. The addon should enable (before it was disabled)

• User impact if declined: The extension stays disabled if installed via policy. We've had this reported by enterprises.
• Fix Landed on Version: N/A
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds one line to just enable the addon after the install.
• String or UUID changes made by this patch:

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9046835 [details]
Bug 1530712 - Enable addon after installation via policy.

Fixes an ESR-only Policy Engine bug. Approved for 60.6esr.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/5d579fb74838

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out 74838 (Bug 1530712) for failing browser_policy_extensions.js: https://hg.mozilla.org/releases/mozilla-esr60/rev/c482211135add40e640a1fff602f073d792c36fa

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-esr60&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&group_state=expanded&revision=5d579fb748388fbbf101efd1e31d3460514e25e7
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=231645281&repo=mozilla-esr60

[task 2019-03-04T14:49:54.623Z] 14:49:54 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | Engine is inactive at the start of the test -
[task 2019-03-04T14:49:54.624Z] 14:49:54 INFO - Leaving test bound policies_headjs_startWithCleanSlate
[task 2019-03-04T14:49:54.626Z] 14:49:54 INFO - Entering test bound test_addon_install
[task 2019-03-04T14:49:54.628Z] 14:49:54 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | Sanity check the temporary file doesn't exist. - true == true -
[task 2019-03-04T14:49:54.629Z] 14:49:54 INFO - Console message: [JavaScript Error: "TypeError: install.addon is null" {file: "resource:///modules/policies/Policies.jsm" line: 568}]
[task 2019-03-04T14:49:54.630Z] 14:49:54 INFO - Buffered messages logged at 14:49:54
[task 2019-03-04T14:49:54.631Z] 14:49:54 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | Addon not installed. -
[task 2019-03-04T14:49:54.632Z] 14:49:54 INFO - TEST-PASS | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | Addon version is correct -
[task 2019-03-04T14:49:54.634Z] 14:49:54 INFO - Buffered messages finished
[task 2019-03-04T14:49:54.635Z] 14:49:54 INFO - TEST-UNEXPECTED-FAIL | browser/components/enterprisepolicies/tests/browser/browser_policy_extensions.js | A promise chain failed to handle a rejection: install.addon is null - stack: onBeforeUIStartup/</<@resource:///modules/policies/Policies.jsm:568:15
[task 2019-03-04T14:49:54.636Z] 14:49:54 INFO - Rejection date: Mon Mar 04 2019 14:49:53 GMT+0000 (UTC) - false == true - JS frame :: resource://testing-common/PromiseTestUtils.jsm :: assertNoUncaughtRejections :: line 257
[task 2019-03-04T14:49:54.637Z] 14:49:54 INFO - Stack trace:
[task 2019-03-04T14:49:54.638Z] 14:49:54 INFO - resource://testing-common/PromiseTestUtils.jsm:assertNoUncaughtRejections:257
[task 2019-03-04T14:49:54.638Z] 14:49:54 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1089
[task 2019-03-04T14:49:54.639Z] 14:49:54 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1058:9
[task 2019-03-04T14:49:54.640Z] 14:49:54 INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:958:9
[task 2019-03-04T14:49:54.641Z] 14:49:54 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59

Comment 7

[Mike Kaply [:mkaply]]

Aryx:

Here is an updated patch.

https://phabricator.services.mozilla.com/D21266

It passes the tests and worked for me locally.

Sorry for the first one.

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/91b0c2e25194

Comment 10

[Emil Ghitta, QA [:emilghitta]]

Hi Mike! Do you have any news regarding the esr try build? The build provided in comment 8 is busted.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Can you test with a recent ESR build? E.g. https://treeherder.mozilla.org/#/jobs?repo=mozilla-esr60&resultStatus=success%2Cpending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=e748e6465ecbcf7ceac1e3af2e37a6f1eb7bb86d&searchStr=build&selectedJob=233065827

1. Click on an "N" for a Nightly build.
2. At the bottom, click on "Job Details".
3. Find the program link. In case of Windows "target.installer.exe" and download it.
4. Install it.
   Let me know if this doesn't help.

Comment 12

[Emil Ghitta, QA [:emilghitta]]

Thanks Sebastian!

I have managed to reproduce this issue using Firefox 60.5.2esr (BuildId:20190221164337).

This issue is verified fixed using Firefox 60.5.3esr (provided in comment 11) on Windows 10 64bit, macOS 10.11.6 and Ubuntu 16.04 64bit.