1530900 - Format conversion happening during texture upload on Mac because of TexStorage

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

We spend an appreciable amount of time in glgConvertTo_32<GLGConverter_ABGR8_ARGB8, (GLGMemory)1>(GLGOperationRec const*, GLDPixelModeRec const*)

We can do better.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

So based on other related functions it looks like that function is converting from ABGR8 to ARGB8. It's not clear what the byte order of those format specifications is though. That being said, I'm confused as to why it thinks we have ABGR8.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

The call to TexSubImage3D that calls glgConvertTo_32<GLGConverter_ABGR8_ARGB8, (GLGMemory)1> has format = GL_BGRA and type = GL_UNSIGNED_BYTE

Comment 3

[Dzmitry Malyshau [:kvark]]

I think our problem is forcing Apple to use RGBA8 as the internal format of textures.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

It turns out this is caused by using TexStorage3D on mac.

Comment 5

[Dzmitry Malyshau [:kvark]]

Fixed by https://phabricator.services.mozilla.com/D21965 and the follow-ups