1530961 - [Search Quantumbar] One-click search in new tab function doesn't open a new tab

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[laszlo.bialis]

Affected versions

• Nightly 67.0a1

Affected platforms

• Win10 x64, macOS 10.14, Ubuntu 16.04

Steps to reproduce

1. Launch Firefox
2. Make sure "browser.urlbar.quantumbar" is set to "true" in about:config
3. Restart the browser
4. Use the same profile as before and type something in the URL bar
5. Right click on a one-click search button
6. From the context menu select the Search in New Tab item.

Expected result

• Search should be performed in a new tab with the selected one-click search engine but with the focus remaining on the tab where the search has been started.

Actual result

• Search is performed in a the same tab from where the text was typed in the URL bar.

Additional notes

• The issue affects Quantumbar only, in Awesomebar the Search in New Tab works ok.

Comment 1

[Marco Bonardo [:mak]]

We can't mark 67 as affected because we're not releasing the QB in 67.

Comment 2

[Mark Banner (:standard8)]

I just noticed, this also always searches using the default search engine rather than the one you're right-clicking on.

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1530961 - Move SearchTestUtils.jsm from browser to toolkit. r?adw

This seems to make more sense as it is currently only handling the search service.

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1530961 - Move waitForSearchNotification from head_search.js to SearchTestUtils.jsm. r?adw

Depends on D22351

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1530961 - Fix the right-click 'search in new tab' option for search one-offs to work in all situations. r?adw

Depends on D22352

Comment 6

[Mark Banner (:standard8)]

So bug 1525101 has actually just landed a fix for this - because we no longer have any more anonymous elements following the search popup move away from URLs.

However, I'll still be landing all of this, since this will at least add a test to make sure we don't break it in future.

Comment 7

[Mark Banner (:standard8)]

(In reply to Mark Banner (:standard8) from comment #6)

So bug 1525101 has actually just landed a fix for this - because we no longer have any more anonymous elements following the search popup move away from URLs.

However, I'll still be landing all of this, since this will at least add a test to make sure we don't break it in future.

Err, actually it broke the context menu for the existing address bar, which probably means my change actually broke the search popup.

I'll figure out a fix that works for everywhere.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e01745bb65d
Move SearchTestUtils.jsm from browser to toolkit. r=adw
https://hg.mozilla.org/integration/autoland/rev/a5c70252fc38
Move waitForSearchNotification from head_search.js to SearchTestUtils.jsm. r=adw
https://hg.mozilla.org/integration/autoland/rev/3815b3ac1823
Fix the right-click 'search in new tab' option for search one-offs to work in all situations. r=adw

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/8e01745bb65d
https://hg.mozilla.org/mozilla-central/rev/a5c70252fc38
https://hg.mozilla.org/mozilla-central/rev/3815b3ac1823