1531060 - All open tabs are closed on firefox version update

Status: RESOLVED INACTIVE

(Firefox :: Session Restore, defect, P3)

Description

[sr21077]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:65.0) Gecko/20100101 Firefox/65.0

Steps to reproduce:

1. I had multiple tabs opened on the firefox.
2. Update the firefox browser to the latest version from (new version - 1 ) version.
3. Update was successful and all the opened tabs before the update did not come up again.

OS : MAC v 10.13.5 ( High Sierra )

Actual results:

Tabs which were opened before the update were not reopened after the update completed. I was presented with default view with single tab / home screen of the browser.

Expected results:

Expected to have all the tabs which were open before update to be available after update or present a warning that all tabs will be closed or will not be available after the update.

Comment 1

[Mike de Boer [:mikedeboer]]

I think this is part of Application Update, since Session Restore already exposes this functionality; the updater just needs to set the appropriate flags (pref) to make it work. We recently used this for bug 603903 too.

Comment 2

[Robert Strong (they/them - no direct email)]

Adam, do you know what is going on here? This sounds like bug 603903 either missed fixing this when restarting for an app update which doesn't make sense due to app update using the common restart code which is where this should be handled if it is a pref as comment #1 states or possibly this is a dupe of bug 603903.

Comment 3

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

I just tested an update from 65.0 to 66.0.2 on macOS Mojave 10.14.2 (and on Windows 10 for good measure) with "Restore previous session" disabled. When I hit the button in Preferences to "Restart to update Firefox", the tabs came back properly. So it's still capable of doing the right thing.

sr21077, it might help to know:

• Does this keep happening?
• Were tabs preserved on previous update restarts?
• Is the "Restore previous session" option set?
• Exactly how are you restarting: is there something in the browser you clicked on, or did you close the browser yourself?

I don't think bug 603903 is involved, I think Mike just mentioned it as a place that explicitly uses it. It's been a while but I think it's meant to work like this:

1. Someone calls Services.startup.quit() with Services.startup.eRestart, like here for some update paths
2. Quit() will notify quit-application observers with data "restart" . (In most places ferocity is initially eAttemptQuit, but this gets promoted to eForceQuit if we were able to get all windows to agree to close)
3. Via the SessionStore observer, we set browser.sessionstore.resume_session_once.
4. That pref prevents clearing some session state.
5. On startup, that pref is checked and used to determine whether to restore the session. (bug 603903 added something before that to clear it if we only set the flag due to OS shutdown, but that only applies to Windows so far)
6. Normally that pref is cleared once the session is loaded.

There are a lot of steps and I really couldn't guess what's going wrong for sr21077 without more info.

Comment 4

[Robert Strong (they/them - no direct email)]

That makes sense but whatever Session Restore needs to operate properly should be fixed by someone that works on and understands Session Restore so moving back to the original component.

Comment 5

[sr21077]

Hello, [e-mail]

Please find my answers below.

sr21077, it might help to know:

Does this keep happening?

Yes , today i updated and it does not restore the tabs that were open before the update.

* Were tabs preserved on previous update restarts? 

No

Is the "Restore previous session" option set?

No

Exactly how are you restarting: is there something in the browser you clicked on, or did you close the browser yourself?

I did browser update in the "About Firefox" -> I click on " Click to Restart" button to update in there after the update was downloaded. I did not close the browser manually.

Comment 6

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Thanks for the info. I've tried to do an update in that way (About Firefox -> Click to Restart) from 65.0, 64.0, and 64.0.2 up to 66.0.2; each time it seems to restore tabs properly.

I agree with Robert that this is more likely a Session Restore issue than Application Update.

Comment 7

[Mike de Boer [:mikedeboer]]

Okay, sr21077, could you copy & paste the info from about:support in a comment here? There might be an addon that's interfering with your experience.
This is a problem that I find unlikely to have only you suffer from, but thus far this is the only report of this behavior. So I'd like to try and figure out what might be wrong with your Firefox installation.
Next time you update & restart, could you take a look at the Browser Console (CMD+Shift+J) and tell us what's reported in there?

Thanks for your help!

Comment 8

[Mike de Boer [:mikedeboer]]

The reporter in bug 1540508 has seen something similar, it seems.

Comment 9

[Mike de Boer [:mikedeboer]]

Closing due to inactivity > 1yr.