1531061 - Add support for a "Just Land It" mode where Lando would autoland the patch when the positive review comes in

Status: NEW

(Conduit :: General, enhancement, P2)

Description

[(no longer active)]

Sometimes I have a super trivial patch that I post and I know that it is ready to land except that it doesn't have r+.

It would be nice if there was a way to give this information to Lando somehow, to tell it: "Just Land It". The way I see this feature working would be that Lando would keep track of when the reviewer would mark the review as accepted and ready to land and would then automatically queue the patch for landing, without the author being in the loop.

This would eliminate one manual step which sometimes I have to take several times per week these days, and would also free me from the mental load of keeping track of these in-flight changes, so that I can fire and forget about these patches unless if the reviewer would request some changes in the patch.

Comment 1

[:glob ✱]

both smacleod and i are sure there's already a bug for this with discussion, however neither of us can find it. so this is the new bug :)

it was kind of discussed on dev-platform in https://groups.google.com/d/topic/mozilla.dev.platform/Z2uvLUxMIxE/discussion (warning: it turns into quite the bikeshed that goes somewhat off topic).

generally speaking the patch author needs to set a "thing" that indicates to phabricator/lando/transplant that a revision can be landed once reviewed.

this signalling for stacks is slightly more complicated, but something like a phabricator tag set on a revision would result in it being autolanded only if all of its children are also ready to land.

Comment 2

[(no longer active)]

Requiring the author setting a "thing" sounds great, and is exactly what I was expecting here too. Thanks!

Comment 3

[:glob ✱]

roughly there's two phases to this:

first: manually with sheriffs

• patch author manually sets Check-in Needed tag in phabriator on a single revision (can be set prior to it being ready to land)
• sheriffs will land that revision using lando, which will automatically land all parent revisions in the stack

then: automatically, opt-out

• moz-phab sets Check-in Needed tag in phabricator on each revision as they are created (with opt-out abilities)
• once all revisions in a stack have been reviewed and have Check-in Needed set, lando will automatically attempt a landing

Comment 4

[Nico Grunbaum [:ng, @chew:mozilla.org]]

Is there any consideration for this feature to require the review bot(s) to have succeeded as well?