Closed Bug 1531075 Opened 3 years ago Closed 3 years ago

createOffer with no transceivers fails

Categories

(Core :: WebRTC: Signaling, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla67
Tracking Status
firefox67 --- fixed

People

(Reporter: bwc, Assigned: bwc)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

This is a degenerate case, but there's nothing in the spec about treating this as an error.

I seem to recall a comment on a spec issue where the Firefox behavior was considered, but I failed to find it. rtcweb-wg/jsep/issues/832 would suggest createOffer wo/transceivers should be supported.

Any gut feeling on priority/rank here? As far as I can see, the primary reason to do this is to improve our test coverage and make wpt sync easier.

Flags: needinfo?(jib)

No-one has complained. I'd say low priority.

Flags: needinfo?(jib)
Rank: 35

Bumping priority mostly so we can re-enable some wpt, and ease wpt sync a little.

Rank: 35 → 21
Priority: P4 → P3
Assignee: nobody → docfaraday
Blocks: 1533020
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/add69e4bd9af
Allow offers to be created/set without any transceivers, re-enable some tests, and fix a mochitest. r=jib

Stepping on my own toes here with bug 1531146. Have updated phabricator.

Flags: needinfo?(docfaraday)
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7314b493edd3
Allow offers to be created/set without any transceivers, re-enable some tests, and fix a mochitest. r=jib
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

The SDP spec requires connection information be present [0], so this degenerate case isn't expressible with SDP, unless we include a top level connection line. Should the Rust SDP parser be changed to support this case? This seems like a bug in the JSEP spec not to also require a top level connection line in this case, and something that will occur as a developer error (which would be helpful to report), more often than it would be used intentionally.

[0] https://tools.ietf.org/html/rfc4566#section-5.7

Flags: needinfo?(docfaraday)

I agree that this case is goofy, and should never have been allowed by the spec (either webrtc-pc or jsep). It might be worth surfacing a warning I suppose, but for now let's just allow it.

Flags: needinfo?(docfaraday)
You need to log in before you can comment on or make changes to this bug.