Closed Bug 1531122 Opened 9 months ago Closed 8 months ago

JsepSessionImpl can erroneously compare a locally-created offer with a locally set answer

Categories

(Core :: WebRTC: Signaling, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bwc, Assigned: bwc)

Details

Attachments

(2 files)

https://jsfiddle.net/5c7mopvk/1/

The key problem here is that there is only a single variable for the most-recently-generated local description, and everything looks fine except the fact that we're comparing an offer to an answer.

Assignee: nobody → docfaraday
Attachment #9052120 - Attachment description: Bug 1531122: (WIP) Keep generated offers and answers separate, and don't clear them when negotiation completes. → Bug 1531122 - Part 0: Remove a bug from a meta file, and test that we aren't comparing offers with answers. r?jib
Pushed by bcampen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ecb3fee21658
Part 0: Remove a bug from a meta file, and test that we aren't comparing offers with answers. r=jib
https://hg.mozilla.org/integration/autoland/rev/a2e425c1f711
Part 1: Keep generated offers and answers separate. r=mjf
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16039 for changes under testing/web-platform/tests
Upstream PR merged
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6409a133fa6a
[wpt PR 16039] - [Gecko Bug 1531122] Part 0: Remove a bug from a meta file, and test that we aren't comparing offers with answers., a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a245f0c9016
[wpt PR 16039] - [Gecko Bug 1531122] Part 0: Remove a bug from a meta file, and test that we aren't comparing offers with answers., a=testonly
You need to log in before you can comment on or make changes to this bug.